From 1eec3d280b1b0352f8b315551365b10e2ecd3762 Mon Sep 17 00:00:00 2001
From: edde746 <86283021+edde746@users.noreply.github.com>
Date: Tue, 24 Feb 2026 17:42:28 +0100
Subject: [PATCH] fix: WinSparkle platform filtering and version display

---
 .github/workflows/build.yml | 8 ++++----
 windows/runner/Runner.rc    | 6 ++++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index c5abc6ac..ac22c958 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -751,10 +751,10 @@ jobs:
               <item>
                 <title>Version ${VERSION}</title>
                 <sparkle:version>${VERSION}</sparkle:version>
-                <sparkle:os>macos</sparkle:os>
                 <enclosure url="https://github.com/edde746/plezy/releases/download/${VERSION}/plezy-macos.dmg"
                            length="${MACOS_DMG_SIZE}" type="application/octet-stream"
-                           sparkle:edSignature="${MACOS_ED_SIG}" />
+                           sparkle:edSignature="${MACOS_ED_SIG}"
+                           sparkle:os="macos" />
               </item>
           XMLEOF
           fi
@@ -765,11 +765,11 @@ jobs:
               <item>
                 <title>Version ${VERSION}</title>
                 <sparkle:version>${VERSION}</sparkle:version>
-                <sparkle:os>windows</sparkle:os>
                 <enclosure url="https://github.com/edde746/plezy/releases/download/${VERSION}/plezy-windows-installer.exe"
                            length="${WIN_INSTALLER_SIZE}" type="application/octet-stream"
                            sparkle:edSignature="${WIN_ED_SIG}"
-                           sparkle:installerArguments="/SILENT /SP-" />
+                           sparkle:installerArguments="/SILENT /SP-"
+                           sparkle:os="windows" />
               </item>
           XMLEOF
           fi
diff --git a/windows/runner/Runner.rc b/windows/runner/Runner.rc
index 88206976..c1b6c6d9 100644
--- a/windows/runner/Runner.rc
+++ b/windows/runner/Runner.rc
@@ -66,8 +66,10 @@ IDI_APP_ICON            ICON                    "resources\\app_icon.ico"
 #define VERSION_AS_NUMBER 1,0,0,0
 #endif
 
-#if defined(FLUTTER_VERSION)
-#define VERSION_AS_STRING FLUTTER_VERSION
+#if defined(FLUTTER_VERSION_MAJOR) && defined(FLUTTER_VERSION_MINOR) && defined(FLUTTER_VERSION_PATCH)
+#define STRINGIFY_(x) #x
+#define STRINGIFY(x) STRINGIFY_(x)
+#define VERSION_AS_STRING STRINGIFY(FLUTTER_VERSION_MAJOR) "." STRINGIFY(FLUTTER_VERSION_MINOR) "." STRINGIFY(FLUTTER_VERSION_PATCH)
 #else
 #define VERSION_AS_STRING "1.0.0"
 #endif