chore: clean up code comments

2026-08-10 20:28:41 +02:00
parent 5611c6785a
commit 69fadc220d
170 changed files with 324 additions and 1765 deletions
@@ -336,8 +336,6 @@ android {

  defaultConfig {
    applicationId = "com.edde746.plezy"
-    // You can update the following values to match your application needs.
-    // For more information, see: https://flutter.dev/to/review-gradle-config.
    minSdk = 25 // Fire OS 6.x (API 25); overrides libmpv-android's minSdk=26
    targetSdk = flutter.targetSdkVersion
    versionCode = flutter.versionCode
@@ -9,17 +9,14 @@
    <!-- Allow minSdk=25 despite libmpv-android declaring minSdk=26 -->
    <uses-sdk tools:overrideLibrary="dev.jdtech.mpv" />

-    <!-- Internet access permissions -->
    <uses-permission android:name="android.permission.INTERNET"/>
    <uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS"/>


-    <!-- PIP and media session foreground service permissions -->
    <uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
    <uses-permission android:name="android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK"/>
    <uses-permission android:name="android.permission.REORDER_TASKS"/>

-    <!-- Background download notifications and foreground service -->
    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
    <uses-permission android:name="android.permission.FOREGROUND_SERVICE_DATA_SYNC"/>

@@ -30,15 +27,11 @@
    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="remove" />


-    <!-- Android TV support (not required, but allow detection) -->
    <uses-feature android:name="android.software.leanback" android:required="false" />
-    <!-- Android TV Watch Next integration -->
    <uses-permission android:name="com.android.providers.tv.permission.WRITE_EPG_DATA"/>
    <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>
-    <!-- Touchscreen not required for TV -->
    <uses-feature android:name="android.hardware.touchscreen" android:required="false" />

-    <!-- Android Automotive OS support -->
    <uses-feature android:name="android.hardware.type.automotive" android:required="false" />

    <application
@@ -63,10 +56,6 @@
            android:configChanges="orientation|keyboardHidden|keyboard|navigation|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
            android:hardwareAccelerated="true"
            android:windowSoftInputMode="adjustResize">
-            <!-- Specifies an Android theme to apply to this Activity as soon as
-                 the Android process has started. This theme is visible to the user
-                 while the Flutter UI initializes. After that, this theme continues
-                 to determine the Window background behind the Flutter UI. -->
            <meta-data
              android:name="io.flutter.embedding.android.NormalTheme"
              android:resource="@style/NormalTheme"
@@ -77,7 +66,6 @@
            <intent-filter>
                <action android:name="android.intent.action.MAIN"/>
                <category android:name="android.intent.category.LAUNCHER"/>
-                <!-- Allow app to appear in Android TV launcher -->
                <category android:name="android.intent.category.LEANBACK_LAUNCHER"/>
            </intent-filter>
            <!-- Deep link handler for Watch Next items -->
@@ -88,7 +76,6 @@
                <data android:scheme="plezy" android:host="play"/>
            </intent-filter>
        </activity>
-        <!-- FileProvider for sharing downloaded files with external players -->
        <provider
            android:name="androidx.core.content.FileProvider"
            android:authorities="com.edde746.plezy.fileprovider"
@@ -119,7 +119,6 @@ class MainActivity : FlutterActivity() {
    }
  }

-  // Auto PiP state
  private var autoPipReady = false
  private var autoPipWidth: Int = 16
  private var autoPipHeight: Int = 9
@@ -106,7 +106,6 @@ internal class TrueHdCarrierSink(
  @Volatile
  private var mismatchGeneration = -1

-  // --- Selection ---

  /**
   * True when this format should ride the carrier.
@@ -193,7 +192,6 @@ internal class TrueHdCarrierSink(
    }
  }

-  // --- Stream path: active delegate only ---

  override fun handleBuffer(buffer: ByteBuffer, presentationTimeUs: Long, encodedAccessUnitCount: Int): Boolean {
    if (!carrierActive) return defaultSink.handleBuffer(buffer, presentationTimeUs, encodedAccessUnitCount)
@@ -96,7 +96,6 @@ class MpvPlayerCore private constructor(
  // output (#1482).
  private val mpvWriteDispatcher = Dispatchers.IO.limitedParallelism(1)

-  // Frame rate matching
  private var frameRateManager: FrameRateManager? = null
  private val handler = Handler(Looper.getMainLooper())

@@ -110,7 +109,6 @@ class MpvPlayerCore private constructor(
    if (Looper.myLooper() == Looper.getMainLooper()) block() else mainHandler.post(block)
  }

-  // Audio focus
  private var audioFocusManager: AudioFocusManager? = null

  @Volatile private var cachedPaused: Boolean = true
@@ -275,7 +273,6 @@ class MpvPlayerCore private constructor(
        Log.d(TAG, "SurfaceView added to content view")
      }

-      // Create MpvPlayer on background thread via coroutine
      scope.launch {
        try {
          if (disposing) {
@@ -74,7 +74,6 @@ open class MpvPlayerPlugin(
  private var initAttemptCounter = 0
  private var activeInitAttempt: Int? = null

-  // FlutterPlugin

  override fun onAttachedToEngine(binding: FlutterPlugin.FlutterPluginBinding) {
    applicationContext = binding.applicationContext
@@ -104,7 +103,6 @@ open class MpvPlayerPlugin(
    takeCoreForTeardown()?.dispose()
  }

-  // ActivityAware

  override fun onAttachedToActivity(binding: ActivityPluginBinding) {
    activity = binding.activity
@@ -141,7 +139,6 @@ open class MpvPlayerPlugin(
    Log.d(tag, "Detached from activity for config changes")
  }

-  // EventChannel.StreamHandler

  override fun onListen(arguments: Any?, events: EventChannel.EventSink?) {
    channels.listen(events)
@@ -151,7 +148,6 @@ open class MpvPlayerPlugin(
    channels.cancel()
  }

-  // MethodChannel.MethodCallHandler

  override fun onMethodCall(call: MethodCall, result: MethodChannel.Result) {
    when (call.method) {
@@ -28,7 +28,6 @@ class BufferingStallPolicyTest {
    loading = loading
  )

-  // The loader's own state, for the case media3 never answers

  @Test
  fun aLoaderThatStoppedAskingForDataCountsAsEnoughBuffer() {
@@ -51,7 +50,6 @@ class BufferingStallPolicyTest {
    assertEquals(Verdict.STALLED, evaluate(bufferedAheadMs = 2_000L, loading = false, loadControlReady = false))
  }

-  // The load control's own verdict

  @Test
  fun aByteCappedBufferBelowTheDurationBarIsStillIndicted() {
@@ -83,7 +81,6 @@ class BufferingStallPolicyTest {
    )
  }

-  // Playback speed

  @Test
  fun aFastForwardNeedsProportionallyMoreMediaBeforeItIsIndicted() {
@@ -107,7 +104,6 @@ class BufferingStallPolicyTest {
    assertEquals(Verdict.STALLED, evaluate(playbackSpeed = -1f))
  }

-  // Progress

  @Test
  fun advancingPositionIsHealthy() {
@@ -138,7 +134,6 @@ class BufferingStallPolicyTest {
    assertEquals(Verdict.STALLED, evaluate(currentPositionMs = position - 5_000))
  }

-  // Timeout

  @Test
  fun frozenPositionWaitsOutTheTimeout() {
@@ -151,7 +146,6 @@ class BufferingStallPolicyTest {
    assertEquals(Verdict.STALLED, evaluate())
  }

-  // Starvation — the loader's problem, not the renderer's

  @Test
  fun emptyBufferIsStarved() {
@@ -203,7 +197,6 @@ class BufferingStallPolicyTest {
    )
  }

-  // Stall clock ownership

  @Test
  fun starvationAndProgressBothRestartTheStallClock() {
@@ -10,7 +10,6 @@ class DvBitstreamSanitizerTest {

  private val sanitizer = DvBitstreamSanitizer()

-  // --- HDR10+ SEI stripping (native DV codec path) ---

  @Test
  fun stripsHdr10PlusPrefixSeiBetweenVclNals() {
@@ -85,7 +84,6 @@ class DvBitstreamSanitizerTest {
    assertArrayEquals(original, remainingBytes(buffer))
  }

-  // --- DV RPU/EL stripping (HEVC fallback path) ---

  @Test
  fun rpuModeStripsRpuAndElButKeepsHdr10PlusSei() {
@@ -111,7 +109,6 @@ class DvBitstreamSanitizerTest {
    assertArrayEquals(concat(vcl1, vcl2), remainingBytes(buffer))
  }

-  // --- Buffer handling ---

  @Test
  fun respectsPositionAndRestoresIt() {
@@ -245,7 +242,6 @@ class DvBitstreamSanitizerTest {
    assertArrayEquals(concat(vcl1, vcl2), remainingBytes(buffer))
  }

-  // --- Helpers ---

  /** Builds an HEVC NAL unit: start code + 2-byte NAL header encoding [nalUnitType] + payload. */
  private fun annexBNal(nalUnitType: Int, payload: ByteArray, startCodeLen: Int = 4): ByteArray {
@@ -24,7 +24,6 @@ class EndOfStreamPolicyTest {
    frameStallMs = frameStallMs
  )

-  // isFinishedFile

  @Test
  fun stuckPastDurationWithNoPictureIsTheEndOfTheFile() {
@@ -65,7 +64,6 @@ class EndOfStreamPolicyTest {
    assertFalse(isFinishedFile(hasPlaybackOutput = false))
  }

-  // fallbackStartPositionMs

  @Test
  fun fallbackResumesStrictlyInsideTheMedia() {
@@ -9,7 +9,6 @@ private const val MIB = 1024 * 1024

 class LoadControlPolicyTest {

-  // autoTargetBufferBytes

  @Test
  fun neverExceedsMedia3sOwnTargetEvenWithHugeMemory() {
@@ -64,7 +63,6 @@ class LoadControlPolicyTest {
    )
  }

-  // readAheadSeconds

  @Test
  fun readAheadReportsSecondsAtAKnownBitrate() {
@@ -86,7 +84,6 @@ class LoadControlPolicyTest {
    assertNull(LoadControlPolicy.readAheadSeconds(64 * MIB, -1L))
  }

-  // bufferDurations

  /**
   * media3 validates the ordering with Guava `Preconditions`, which is a plain throw rather than
@@ -172,7 +169,6 @@ class LoadControlPolicyTest {
    }
  }

-  // BufferTier.fromWire

  @Test
  fun theWireNamesMatchTheDartNativeValues() {
@@ -52,7 +52,6 @@ class RawPositionAudioOutputTest {
    return output to listener
  }

-  // Release reporting

  /**
   * A parked track is never going to release, so its flush has to be answered at once. Deferring
@@ -116,7 +115,6 @@ class RawPositionAudioOutputTest {
    assertEquals(1, listener.releasedCount)
  }

-  // Reuse

  @Test
  fun aParkedOutputIsHandedBackForAnIdenticalConfig() {
@@ -178,7 +176,6 @@ class RawPositionAudioOutputTest {
    assertEquals(1, secondListener.underrunCount)
  }

-  // Eviction — the overlap media3 itself tolerates, kept tolerable

  /**
   * The replacement is deliberately built while the evicted track is still going away. Refusing
@@ -221,7 +218,6 @@ class RawPositionAudioOutputTest {
    assertEquals(1, listener.releasedCount)
  }

-  // Fakes

  private class RecordingListener : AudioOutput.Listener {
    var releasedCount = 0
@@ -7,7 +7,6 @@ import org.junit.Test

 class ResumeStallPolicyTest {

-  // checkWindowMs

  @Test
  fun windowFloorsAtDefaultForNormalFrameRates() {
@@ -39,7 +38,6 @@ class ResumeStallPolicyTest {
    assertEquals(1000L, ResumeStallPolicy.checkWindowMs(formatFps = null, detectedFps = null, speed = 1f))
  }

-  // evaluate

  @Test
  fun advancingFramesAreHealthy() {
@@ -51,7 +51,6 @@ class TrueHdCarrierSinkTest {
    blocked: Boolean = false
  ) = TrueHdCarrierSink(normal, carrier, { routeAvailable }, { blocked })

-  // --- Selection ---

  /**
   * TrueHD is the carrier or it is decoded. Falling through to the normal sink would hand media3
@@ -154,7 +153,6 @@ class TrueHdCarrierSinkTest {
    assertEquals(0, listener.capabilityInvalidations)
  }

-  // --- Rate-family mismatch discovered mid-stream ---

  /**
   * Selection reads Format.sampleRate; the rate family is only certain once a major sync is parsed.
@@ -289,7 +287,6 @@ class TrueHdCarrierSinkTest {
    assertTrue(carrierSink.supportsFormat(ac3))
  }

-  // --- Back pressure ---

  /**
   * The regression this exists for: a delegate that refuses a burst part-way through a sample must
@@ -336,7 +333,6 @@ class TrueHdCarrierSinkTest {
    assertTrue(carrierSink.hasPendingData())
  }

-  // --- Routing of controls ---

  @Test
  fun persistentControlsReachBothDelegates() {
@@ -11,7 +11,6 @@ default_platform(:android)
 platform :android do
  desc "Build and deploy to Google Play Store"
  lane :release do
-    # Get version from pubspec.yaml
    pubspec_path = File.join(PROJECT_ROOT, "pubspec.yaml")
    pubspec_content = File.read(pubspec_path)
    version_match = pubspec_content.match(/version:\s*(.+)\+(\d+)/)
@@ -26,7 +25,6 @@ platform :android do

    git_commit = `git -C #{PROJECT_ROOT_ARG} rev-parse --short HEAD`.strip

-    # Build the Flutter app
    sh("cd #{PROJECT_ROOT_ARG} && flutter build appbundle --dart-define=ENABLE_SENTRY=true --dart-define=GIT_COMMIT=#{git_commit} --dart-define=SENTRY_ENVIRONMENT=play-store --dart-define=SENTRY_DIST=play-store --obfuscate --split-debug-info=debug-info/android-aab --extra-gen-snapshot-options=--save-obfuscation-map=debug-info/android-aab/obfuscation.map.json")
    sh("cd #{PROJECT_ROOT_ARG} && SENTRY_DIST=play-store ./scripts/upload-symbols.sh android-aab")

@@ -37,7 +35,6 @@ platform :android do
      aab: "../build/app/outputs/bundle/release/app-release.aab"
    )

-    # Build universal APK for Amazon Appstore (doesn't accept AABs, excludes x86 via env var)
    sh("cd #{PROJECT_ROOT_ARG} && AMAZON=1 flutter build apk --release --dart-define=ENABLE_SENTRY=true --dart-define=GIT_COMMIT=#{git_commit} --dart-define=SENTRY_ENVIRONMENT=amazon --dart-define=SENTRY_DIST=amazon --obfuscate --split-debug-info=debug-info/android-apk --extra-gen-snapshot-options=--save-obfuscation-map=debug-info/android-apk/obfuscation.map.json")
    sh("cd #{PROJECT_ROOT_ARG} && SENTRY_DIST=amazon ./scripts/upload-symbols.sh android-apk")