yorickr/plezy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tvos): make EAC3 playback conform to Dolby's guidance

Browse Source 
Groundwork for #1300. Establishes the session, buffering and route
handling Dolby's application guide prescribes, and adds the diagnostic
arm needed to find out whether Apple's sample-buffer renderer can carry
Atmos objects at all.

Audio session, per the guide's sequence:

- Adopt the long-form playback profile in one atomic call at app launch
  and activate the session there. The SDK only accepts that policy with
  category Playback, a Default/MoviePlayback/SpokenAudio mode and no
  options, so it cannot be assembled from separate calls.
- Report the resolved rendering mode in the player, hidden unless the
  system resolves it. Apple only resolves it for CarPlay and AirPlay, so
  an unresolved value means unknown, never "not Dolby".

Diagnostics (Apple TV only, Settings > Video Playback > Atmos Output Test):

- Add a sample-buffer arm. It reads the asset with AVAssetReader at
  outputSettings nil and hands the untouched compressed buffers and the
  untouched format description straight to the renderer, with a variant
  that rebuilds the description the way playback builds it. Every
  existing mode went through AVPlayer, so nothing exercised the path
  playback actually uses; this is what tells us whether the renderer or
  our construction is at fault.
- Add an AirPlay route picker. AirPlay is the only route where the system
  resolves the rendering mode and the supported channel layouts, so it is
  what makes those observations reachable at all, and the AVPlayer arms
  now allow external playback so every arm can be compared on the same
  destination.
- Add a session-mode toggle for the one profile difference between the
  guide and previous playback behaviour.
- Report the session profile, supported layouts, both format
  descriptions, the magic cookie and the renderer status, and release the
  session on stop so a failed run cannot contaminate the next one.

Also bumps MPVKit to 1.0.14, which carries the matching audio output
work: the channel layout AVFoundation itself uses for Dolby content, a
renderer-failure observer so the fallback to PCM can actually run, the
prescribed feed ordering and preroll, flush recovery that re-supplies the
discarded audio instead of shifting later audio into its place, and
capability-driven fallback on route and capability changes.

This does not yet fix #1300. Whether the sample-buffer renderer can carry
JOC is still unknown; it removes every difference from the documented
setup that could explain the failure, and gives us the arm to answer it
on real hardware.
This commit is contained in:
edde746
2026-07-26 20:42:58 +02:00
parent a56b9a3dfb
commit 6c14049e95
62 changed files with 1743 additions and 148 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/i18n/strings_da.g.dart
+32 -4
View File
@@ -418,6 +418,15 @@ class _Translations$settings$da extends Translations$settings$en {
@override String get atmosTestRawStreamDescription => 'Streamer testfilen præcis som Atmos-afspilning i afspilleren. Kræver testfilens URL.';
@override String get atmosTestRawFile => 'Rå EAC3-fil';
@override String get atmosTestRawFileDescription => 'Afspiller testfilen med kendt længde. Kræver testfilens URL.';
@override String get atmosTestAsbarNative => 'Sample-buffer-renderer (native)';
@override String get atmosTestAsbarNativeDescription => 'Sender filens urørte komprimerede lyd direkte til systemets renderer. Kræver testfilens URL.';
@override String get atmosTestAsbarGenerated => 'Sample-buffer-renderer (genopbygget)';
@override String get atmosTestAsbarGeneratedDescription => 'Det samme, men med lydbeskrivelsen opbygget som ved afspilning. Kræver testfilens URL.';
@override String get atmosTestSessionMode => 'Brug filmafspilningstilstand';
@override String get atmosTestSessionModeDescription => 'Fra bruger den tilstand, Dolby dokumenterer. Til bruger den tidligere tilstand.';
@override String get atmosTestShowRoutePicker => 'Vælg AirPlay-udgang';
@override String get atmosTestHideRoutePicker => 'Skjul AirPlay-udgangsvælger';
@override String get atmosTestRoutePickerDescription => 'Sender testen til en AirPlay-modtager. Kun AirPlay rapporterer den valgte lydtilstand.';
@override String get atmosTestStop => 'Stop test';
@override String get atmosTestUrl => 'Testfilens URL';
@override String get atmosTestUrlDescription => 'HTTP-URL til en rå .ec3 Dolby Atmos-fil (f.eks. udtrukket med ffmpeg)';
@@ -1514,6 +1523,11 @@ class _Translations$videoSettings$da extends Translations$videoSettings$en {
@override String get audioOutput => 'Lydoutput';
@override String get performanceOverlay => 'Ydelsesoverlay';
@override String get audioPassthrough => 'Lyd-passthrough';
@override String get audioOutputDolbyAtmos => 'Dolby Atmos';
@override String get audioOutputDolbyAudio => 'Dolby Audio';
@override String get audioOutputSurround => 'Surround';
@override String get audioOutputSpatial => 'Rumlig lyd';
@override String get audioOutputStereo => 'Stereo';
@override String get audioNormalization => 'Normalisér lydstyrke';
@override String get audioDownmix => 'Downmix til stereo';
}
@@ -2463,6 +2477,15 @@ extension on TranslationsDa {
'settings.atmosTestRawStreamDescription' => 'Streamer testfilen præcis som Atmos-afspilning i afspilleren. Kræver testfilens URL.',
'settings.atmosTestRawFile' => 'Rå EAC3-fil',
'settings.atmosTestRawFileDescription' => 'Afspiller testfilen med kendt længde. Kræver testfilens URL.',
'settings.atmosTestAsbarNative' => 'Sample-buffer-renderer (native)',
'settings.atmosTestAsbarNativeDescription' => 'Sender filens urørte komprimerede lyd direkte til systemets renderer. Kræver testfilens URL.',
'settings.atmosTestAsbarGenerated' => 'Sample-buffer-renderer (genopbygget)',
'settings.atmosTestAsbarGeneratedDescription' => 'Det samme, men med lydbeskrivelsen opbygget som ved afspilning. Kræver testfilens URL.',
'settings.atmosTestSessionMode' => 'Brug filmafspilningstilstand',
'settings.atmosTestSessionModeDescription' => 'Fra bruger den tilstand, Dolby dokumenterer. Til bruger den tidligere tilstand.',
'settings.atmosTestShowRoutePicker' => 'Vælg AirPlay-udgang',
'settings.atmosTestHideRoutePicker' => 'Skjul AirPlay-udgangsvælger',
'settings.atmosTestRoutePickerDescription' => 'Sender testen til en AirPlay-modtager. Kun AirPlay rapporterer den valgte lydtilstand.',
'settings.atmosTestStop' => 'Stop test',
'settings.atmosTestUrl' => 'Testfilens URL',
'settings.atmosTestUrlDescription' => 'HTTP-URL til en rå .ec3 Dolby Atmos-fil (f.eks. udtrukket med ffmpeg)',
@@ -2690,6 +2713,8 @@ extension on TranslationsDa {
'videoControls.language' => 'Sprog',
'videoControls.noSubtitlesFound' => 'Ingen undertekster fundet',
'videoControls.noSubtitlesAvailable' => 'Ingen undertekster tilgængelige',
_ => null,
} ?? switch (path) {
'videoControls.noAudioTracksAvailable' => 'Ingen lydspor tilgængelige',
'videoControls.noTracksAvailable' => 'Ingen spor tilgængelige',
'videoControls.subtitleDownloaded' => 'Undertekst downloadet',
@@ -2699,8 +2724,6 @@ extension on TranslationsDa {
'messages.markedAsWatched' => 'Markeret som set',
'messages.markedAsUnwatched' => 'Markeret som uset',
'messages.markedAsWatchedOffline' => 'Markeret som set (synkroniseres online)',
_ => null,
} ?? switch (path) {
'messages.markedAsUnwatchedOffline' => 'Markeret som uset (synkroniseres online)',
'messages.autoRemovedWatchedDownload' => ({required Object title}) => 'Automatisk fjernet: ${title}',
'messages.autoRemovedWatchedDownloads' => ({required num n}) => (_root.$meta.cardinalResolver ?? PluralResolvers.cardinal('da'))(n, one: 'Fjernede automatisk ${n} set download', other: 'Fjernede automatisk ${n} sete downloads', ),
@@ -3204,6 +3227,8 @@ extension on TranslationsDa {
'watchTogether.codeMustBe5Chars' => 'Sessionskode skal være 5 tegn',
'watchTogether.joinInstructions' => 'Indtast værtens sessionskode for at deltage.',
'watchTogether.failedToCreate' => 'Kunne ikke oprette session',
_ => null,
} ?? switch (path) {
'watchTogether.failedToJoin' => 'Kunne ikke deltage i session',
'watchTogether.sessionCodeCopied' => 'Sessionskode kopieret til udklipsholder',
'watchTogether.relayUnreachable' => 'Relayserveren kan ikke nås. Blokering hos internetudbyderen kan forhindre Se sammen.',
@@ -3213,8 +3238,6 @@ extension on TranslationsDa {
'watchTogether.joinCurrentPlaybackDescription' => 'Hop tilbage til det værten ser nu',
'watchTogether.failedToOpenCurrentPlayback' => 'Kunne ikke åbne nuværende afspilning',
'watchTogether.participantJoined' => ({required Object name}) => '${name} deltog',
_ => null,
} ?? switch (path) {
'watchTogether.participantLeft' => ({required Object name}) => '${name} forlod',
'watchTogether.participantPaused' => ({required Object name}) => '${name} satte på pause',
'watchTogether.participantResumed' => ({required Object name}) => '${name} genoptog',
@@ -3413,6 +3436,11 @@ extension on TranslationsDa {
'videoSettings.audioOutput' => 'Lydoutput',
'videoSettings.performanceOverlay' => 'Ydelsesoverlay',
'videoSettings.audioPassthrough' => 'Lyd-passthrough',
'videoSettings.audioOutputDolbyAtmos' => 'Dolby Atmos',
'videoSettings.audioOutputDolbyAudio' => 'Dolby Audio',
'videoSettings.audioOutputSurround' => 'Surround',
'videoSettings.audioOutputSpatial' => 'Rumlig lyd',
'videoSettings.audioOutputStereo' => 'Stereo',
'videoSettings.audioNormalization' => 'Normalisér lydstyrke',
'videoSettings.audioDownmix' => 'Downmix til stereo',
'performanceOverlay.color' => 'Farve',