fix(plex): validate a failover candidate before switching the live endpoint

A transient GET failure on a healthy endpoint could park the client on an
unreachable fallback (e.g. the server host's Docker bridge gateway, which
plex.tv advertises as a local connection) for a full connect timeout, failing
every request in flight during that window (log bbr90).

The cascade now probes each candidate with an unauthenticated /identity
request under the discovery-race budget and only switches when it answers as
the expected server, mirroring the Jellyfin trust gate. Unreachable-looking
private IPv4 candidates stay in the list — a client on the server host can
legitimately reach them, so reachability is probed, not inferred.
This commit is contained in:
edde746
2026-08-08 12:18:32 +02:00
parent e6be5f9fef
commit 7437b43207
5 changed files with 181 additions and 2 deletions
+5 -2
View File
@@ -620,8 +620,11 @@ class PlexServer {
}
for (final connection in connections) {
// Skip endpoints that are never reachable from an external client:
// Docker bridge addresses and IPv6 link-local / all-zeros addresses.
// Skip endpoints that are never reachable from any client: IPv6
// link-local / all-zeros addresses. Private IPv4 addresses (including
// Docker bridge gateways) are deliberately kept — a client running on
// the server host itself can reach them, so reachability is probed at
// failover time (PlexClient's validateCandidate), not inferred here.
if (_isUnreachableAddress(connection.address)) {
continue;
}
+46
View File
@@ -332,6 +332,12 @@ class PlexClient
final Future<void> Function(String newBaseUrl)? _onEndpointChanged;
final VoidCallback? _onAllEndpointsExhausted;
/// Test seam for [_validateFailoverCandidate]'s ephemeral probe client,
/// mirroring [JellyfinClient.forTesting]'s `endpointProbeHttpClientFactory`.
/// Each validation constructs (and closes) its own client, so this is a
/// factory rather than a shared instance.
final http.Client Function()? _endpointProbeHttpClientFactory;
/// Server identifier - all PlexMetadataDto items created by this client are tagged with this
@override
final ServerId serverId;
@@ -460,6 +466,7 @@ class PlexClient
this._onEndpointChanged,
this._onAllEndpointsExhausted,
http.Client? httpClient,
this._endpointProbeHttpClientFactory,
}) {
LogRedactionManager.registerServer(config.baseUrl, config.token);
@@ -474,6 +481,7 @@ class PlexClient
prioritizedEndpoints: prioritizedEndpoints ?? const [],
onEndpointSwitch: (newBaseUrl, {required persist}) => _handleEndpointSwitch(newBaseUrl, persist: persist),
onAllEndpointsExhausted: _onAllEndpointsExhausted,
validateCandidate: _validateFailoverCandidate,
);
}
@@ -490,6 +498,8 @@ class PlexClient
String? serverName,
required http.Client httpClient,
List<String>? prioritizedEndpoints,
http.Client Function()? endpointProbeHttpClientFactory,
VoidCallback? onAllEndpointsExhausted,
List<({String identifier, String gridEndpoint})> epgProviders = const [],
String? homeHubKey,
String? promotedHubKey,
@@ -502,6 +512,8 @@ class PlexClient
serverName: serverName,
httpClient: httpClient,
prioritizedEndpoints: prioritizedEndpoints,
endpointProbeHttpClientFactory: endpointProbeHttpClientFactory,
onAllEndpointsExhausted: onAllEndpointsExhausted,
);
client._providerLibraries = const [];
client._providerEpg = epgProviders;
@@ -2920,6 +2932,40 @@ class PlexClient
}
}
/// Trust gate for endpoint failover: before the cascade may switch to a
/// fallback candidate, it must answer the unauthenticated `/identity` probe
/// quickly *and* identify as this client's server.
///
/// plex.tv advertises every interface of the server host as a connection
/// candidate, including addresses only that host can reach (e.g. its Docker
/// bridge gateway) — whether such an address works is a property of the
/// session, not the address, so it can only be probed, not filtered. Without
/// this gate one transient error on a healthy endpoint parked the live base
/// URL on a dead candidate for a full connect timeout (log bbr90).
///
/// The probe is deliberately unauthenticated — the token must not be sent to
/// an endpoint whose identity is unconfirmed — and uses the discovery race's
/// budget: every viable candidate already answered within it at discovery
/// time. Cancellations propagate to abort the cascade; other probe failures
/// propagate and reject the candidate ([FailoverHttpClient] semantics).
Future<bool> _validateFailoverCandidate(String candidateBaseUrl, AbortController? abort) async {
LogRedactionManager.registerServerUrl(candidateBaseUrl);
final probe = MediaServerHttpClient(
client: _endpointProbeHttpClientFactory?.call(),
baseUrl: candidateBaseUrl,
defaultHeaders: const {'Accept': 'application/json'},
connectTimeout: MediaServerTimeouts.connectionRace,
receiveTimeout: MediaServerTimeouts.connectionRace,
);
try {
final response = await probe.get('/identity', abort: abort);
if (response.statusCode != 200) return false;
return _getMediaContainer(response)?['machineIdentifier']?.toString() == serverId;
} finally {
probe.close();
}
}
/// Validate and apply a Plex Home identity in place. The candidate token is
/// first checked against the authenticated root endpoint, whose
/// `machineIdentifier` must still identify this clients server. Provider