yorickr/plezy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(player): isolate dispose teardown races

Browse Source
This commit is contained in:
edde746
2026-06-13 13:23:29 +02:00
parent 1e40d21bd8
commit 75ba6b0627
2 changed files with 46 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/mpv/player/player_base.dart
+16 -4
View File
@@ -757,11 +757,23 @@ abstract class PlayerBase with PlayerStreamControllersMixin implements Player {
if (_disposed) return;
_disposed = true;
await _eventSubscription?.cancel();
try {
await _eventSubscription?.cancel();
} on PlatformException catch (e, st) {
appLogger.d('Player event stream already detached during dispose', error: e, stackTrace: st);
} on MissingPluginException catch (e, st) {
appLogger.d('Player event stream plugin missing during dispose', error: e, stackTrace: st);
}
await _logSubscription?.cancel();
await methodChannel.invokeMethod('dispose', {
'preserveDisplayMode': preserveDisplayMode,
}); // Direct call — already guarded by _disposed check above
try {
await methodChannel.invokeMethod('dispose', {
'preserveDisplayMode': preserveDisplayMode,
}); // Direct call — already guarded by _disposed check above
} on PlatformException catch (e, st) {
appLogger.w('Player native dispose failed during teardown', error: e, stackTrace: st);
} on MissingPluginException catch (e, st) {
appLogger.w('Player native dispose plugin missing during teardown', error: e, stackTrace: st);
}
await closeStreamControllers();
}
}