fix: resolve all dart analyze warnings

- Migrate RadioListTile to RadioGroup API (Flutter 3.32+)
- Guard BuildContext usage across async gaps
- Use const BorderRadius.all / EdgeInsets.all constructors
- Extract nested ternaries into helpers
- Prefer .first over [0], ??= over if-null assignment
- Prefix unused FocusNode params with _
- Add library directive for dangling doc comments
This commit is contained in:
edde746
2026-02-23 13:50:56 +01:00
parent 8918bdc93e
commit 8f50da4a75
19 changed files with 123 additions and 125 deletions
+3 -3
View File
@@ -1157,6 +1157,7 @@ class VideoPlayerScreenState extends State<VideoPlayerScreen> with WidgetsBindin
/// Restore ambient lighting from persisted setting
Future<void> _restoreAmbientLighting() async {
final shaderProvider = context.read<ShaderProvider>();
final settings = await SettingsService.getInstance();
if (!settings.getAmbientLighting()) return;
@@ -1177,7 +1178,6 @@ class VideoPlayerScreenState extends State<VideoPlayerScreen> with WidgetsBindin
final outputAspect = playerSize.width / playerSize.height;
// Clear shaders — ambient lighting and shaders are mutually exclusive
final shaderProvider = context.read<ShaderProvider>();
if (shaderProvider.isShaderEnabled) {
await _shaderService!.applyPreset(ShaderPreset.none);
shaderProvider.setCurrentPreset(ShaderPreset.none);
@@ -1212,6 +1212,7 @@ class VideoPlayerScreenState extends State<VideoPlayerScreen> with WidgetsBindin
Future<void> _toggleAmbientLighting() async {
final ambientLighting = _ambientLightingService;
if (ambientLighting == null || !ambientLighting.isSupported) return;
final shaderProvider = context.read<ShaderProvider>();
if (ambientLighting.isEnabled) {
await ambientLighting.disable();
@@ -1232,7 +1233,6 @@ class VideoPlayerScreenState extends State<VideoPlayerScreen> with WidgetsBindin
final outputAspect = playerSize.width / playerSize.height;
// Clear shaders — ambient lighting and shaders are mutually exclusive
final shaderProvider = context.read<ShaderProvider>();
if (shaderProvider.isShaderEnabled) {
await _shaderService!.applyPreset(ShaderPreset.none);
shaderProvider.setCurrentPreset(ShaderPreset.none);
@@ -1248,7 +1248,7 @@ class VideoPlayerScreenState extends State<VideoPlayerScreen> with WidgetsBindin
final settings = await SettingsService.getInstance();
settings.setAmbientLighting(ambientLighting.isEnabled);
setState(() {});
if (mounted) setState(() {});
}
/// Toggle between contain and cover modes only (for pinch gesture)