From 96f7bd431cac514dca9ba7c469cb1a66071a3b17 Mon Sep 17 00:00:00 2001 From: edde746 <86283021+edde746@users.noreply.github.com> Date: Tue, 3 Mar 2026 23:23:06 +0100 Subject: [PATCH] fix: ExoPlayer logs never reaching Dart log output setLogLevel silently no-oped because initialized was false at call time. emitLog gated all levels behind debugLoggingEnabled which was never set. --- .../main/kotlin/com/edde746/plezy/exoplayer/ExoPlayerCore.kt | 2 +- lib/mpv/player/platform/player_android.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/android/app/src/main/kotlin/com/edde746/plezy/exoplayer/ExoPlayerCore.kt b/android/app/src/main/kotlin/com/edde746/plezy/exoplayer/ExoPlayerCore.kt index a0411451..478d9d68 100644 --- a/android/app/src/main/kotlin/com/edde746/plezy/exoplayer/ExoPlayerCore.kt +++ b/android/app/src/main/kotlin/com/edde746/plezy/exoplayer/ExoPlayerCore.kt @@ -124,7 +124,7 @@ class ExoPlayerCore(private val activity: Activity) : Player.Listener { "info" -> Log.i(TAG, "[$prefix] $message") else -> Log.d(TAG, "[$prefix] $message") } - if (debugLoggingEnabled) { + if (debugLoggingEnabled || level == "error" || level == "warn") { delegate?.onEvent("log-message", mapOf( "prefix" to prefix, "level" to level, "text" to message )) diff --git a/lib/mpv/player/platform/player_android.dart b/lib/mpv/player/platform/player_android.dart index a3599f31..b80cf2e8 100644 --- a/lib/mpv/player/platform/player_android.dart +++ b/lib/mpv/player/platform/player_android.dart @@ -402,7 +402,7 @@ class PlayerAndroid extends PlayerBase { @override Future setLogLevel(String level) async { checkDisposed(); - if (!initialized) return; + await _ensureInitialized(); await methodChannel.invokeMethod('setLogLevel', {'level': level}); } }