yorickr/plezy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: guard cache put against non-Map response data

Browse Source
This commit is contained in:
edde746
2026-03-20 08:29:36 +01:00
parent 7a68218439
commit bafba0b151
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/services/plex_client.dart
+10 -6
View File
@@ -735,9 +735,7 @@ class PlexClient {
} }
try { try {
final response = await networkCall(); final response = await networkCall();
if (cacheResponse && response.data != null) { if (cacheResponse) await _cacheResponseData(cacheKey, response.data);
await _cache.put(serverId, cacheKey, response.data);
}
return parseResponse(response); return parseResponse(response);
} catch (e) { } catch (e) {
// On forceRefresh, still try cache as last resort on network error // On forceRefresh, still try cache as last resort on network error
@@ -763,12 +761,18 @@ class PlexClient {
if (cached != null) return parseCache(cached); if (cached != null) return parseCache(cached);
if (_offlineMode) return null; if (_offlineMode) return null;
final response = await networkCall(); final response = await networkCall();
if (cacheResponse && response.data != null) { if (cacheResponse) await _cacheResponseData(cacheKey, response.data);
await _cache.put(serverId, cacheKey, response.data);
}
return parseResponse(response); return parseResponse(response);
} }
Future<void> _cacheResponseData(String cacheKey, dynamic data) async {
if (data is Map<String, dynamic>) {
await _cache.put(serverId, cacheKey, data);
} else if (data != null) {
appLogger.w('Unexpected response type for $cacheKey: ${data.runtimeType}');
}
}
/// Get first metadata JSON from response data /// Get first metadata JSON from response data
Map<String, dynamic>? _getFirstMetadataJsonFromData(Map<String, dynamic>? data) => Map<String, dynamic>? _getFirstMetadataJsonFromData(Map<String, dynamic>? data) =>
PlexCacheParser.extractFirstMetadata(data); PlexCacheParser.extractFirstMetadata(data);