fix(player): start the TV player with its chrome down
A television raised the whole OSD and timebar on every playback start. The chrome controller is born visible, and its auto-hide clock cannot arm until the first frame lands, so the controls did not merely appear early: they appeared exactly when the picture did, and then sat over the opening five seconds of every movie and episode. The timeline is gated behind the first frame, so the bar materialised on top of the video rather than over the loading spinner, which is what makes it read as a pop-up rather than as chrome that was already there. The route now opens with no chrome on TV. Nothing is lost: the loading spinner and buffering overlay are their own overlays, the screen focus node owns back, and the first D-pad press raises the controls the way it already does after every auto-hide. Pointer and touch platforms keep the chrome, where the viewer's hand is on the surface and the title and back affordance belong over the spinner. Initial presentation now follows initial visibility. They were separate: seeding only visibility would leave the route claiming its chrome was still presented, so PlayerNavigationCoordinator would read back as "hide the chrome", hide() would no-op against chrome that was never up, and the press would be swallowed instead of leaving the player. Controls that mount with the chrome already down now claim focus themselves. Focus normally reaches them through the hide transition, and their own autofocus cannot win it back because the screen node took it during the loading phase. Left alone, the screen node kept primary focus and its self-heal raised the entire OSD on the first D-pad press, which put the chrome straight back over the picture and bypassed the transient seek and transport indicators. Both player spinners now carry a label. They were bare progress indicators, so a screen reader announced nothing at all while the picture was coming up, and the TV Maestro flows had no way left to tell a loading player from a playing one once the Pause button stopped appearing on its own. The two TV flows are repaired to match. They waited on that button, and now wait for the labelled spinner to clear, which cannot happen before the media is opened. 05 additionally reaches Search by D-pad rather than a percentage coordinate, because a tap flips InputModeTracker to pointer mode and collapses the rail it is aiming at, and it gates on the play-next prompt's own Cancel action: "Next Episode" is also the credits skip button, so the old assertion could pass without the prompt ever opening. close #1765
This commit is contained in:
@@ -79,7 +79,7 @@ extension _VideoPlayerBuildMethods on VideoPlayerScreenState {
|
||||
Widget _buildLoadingSpinner() {
|
||||
return const Scaffold(
|
||||
backgroundColor: Colors.black,
|
||||
body: Center(child: CircularProgressIndicator(color: Colors.white)),
|
||||
body: Center(child: PlayerLoadingIndicator()),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -95,7 +95,7 @@ extension _VideoPlayerBuildMethods on VideoPlayerScreenState {
|
||||
fit: StackFit.expand,
|
||||
children: [
|
||||
Video(player: bootstrapPlayer, hasFirstFrame: _hasFirstFrame),
|
||||
const Center(child: CircularProgressIndicator(color: Colors.white)),
|
||||
const Center(child: PlayerLoadingIndicator()),
|
||||
],
|
||||
);
|
||||
}
|
||||
|
||||
@@ -46,6 +46,28 @@ class VideoPlayerMacPipPlaceholder extends StatelessWidget {
|
||||
}
|
||||
}
|
||||
|
||||
/// The player's loading spinner.
|
||||
///
|
||||
/// Labelled rather than silent: a bare [CircularProgressIndicator] contributes
|
||||
/// no semantics at all, so a screen reader announced nothing while the picture
|
||||
/// was still coming up. The label also makes "the first frame has not rendered
|
||||
/// yet" an observable state instead of something inferred from the chrome,
|
||||
/// which a television no longer raises on startup (#1765).
|
||||
class PlayerLoadingIndicator extends StatelessWidget {
|
||||
final double strokeWidth;
|
||||
|
||||
const PlayerLoadingIndicator({super.key, this.strokeWidth = 4});
|
||||
|
||||
@override
|
||||
Widget build(BuildContext context) {
|
||||
return CircularProgressIndicator(
|
||||
color: Colors.white,
|
||||
strokeWidth: strokeWidth,
|
||||
semanticsLabel: t.videoControls.loadingVideo,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
class VideoPlayerBufferingOverlay extends StatelessWidget {
|
||||
final ValueListenable<bool> isBuffering;
|
||||
final ValueListenable<bool> hasFirstFrame;
|
||||
@@ -77,7 +99,7 @@ class VideoPlayerBufferingOverlay extends StatelessWidget {
|
||||
child: Container(
|
||||
padding: const EdgeInsets.all(20),
|
||||
decoration: BoxDecoration(color: Colors.black.withValues(alpha: 0.5), shape: BoxShape.circle),
|
||||
child: const CircularProgressIndicator(color: Colors.white, strokeWidth: 3),
|
||||
child: const PlayerLoadingIndicator(strokeWidth: 3),
|
||||
),
|
||||
),
|
||||
),
|
||||
|
||||
@@ -135,6 +135,17 @@ bool shouldAutoStartReloadedMedia({
|
||||
required bool startPaused,
|
||||
}) => wasPlayingBeforeReload && !watchTogetherOwnsStart && !startPaused;
|
||||
|
||||
/// Whether a freshly opened player route starts with its chrome up.
|
||||
///
|
||||
/// A television starts with the controls down. Auto-hide cannot even arm until
|
||||
/// the first frame lands, so chrome raised by the route opening would park the
|
||||
/// whole OSD and timebar over the first seconds of picture (#1765). The route
|
||||
/// keeps its own loading surface and buffering overlay, the screen focus node
|
||||
/// owns back, and the first D-pad press raises the chrome, so a remote loses
|
||||
/// nothing. Pointer and touch platforms keep it: the viewer's hand is already
|
||||
/// on the surface, and the title and back affordance belong over the spinner.
|
||||
bool playerChromeStartsVisible({required bool isTv}) => !isTv;
|
||||
|
||||
/// Builds an item-agnostic subtitle preference for an episode replacement.
|
||||
///
|
||||
/// Source ids and sidecar URIs belong to the current media item. Only the
|
||||
@@ -737,7 +748,15 @@ class VideoPlayerScreenState extends State<VideoPlayerScreen> with WidgetsBindin
|
||||
bool _hasFatalPlaybackError = false;
|
||||
|
||||
final ValueNotifier<bool> _isExiting = ValueNotifier<bool>(false);
|
||||
final PlayerChromeController _chromeController = PlayerChromeController();
|
||||
final PlayerChromeController _chromeController = PlayerChromeController(
|
||||
initiallyVisible: playerChromeStartsVisible(isTv: PlatformDetector.isTV()),
|
||||
);
|
||||
|
||||
/// Lets startup-policy coverage assert the chrome this route actually opened
|
||||
/// with, rather than a controller the test seeded itself.
|
||||
@visibleForTesting
|
||||
PlayerChromeController get chromeController => _chromeController;
|
||||
|
||||
late final PlayerNavigationCoordinator _playerNavigationCoordinator;
|
||||
|
||||
@override
|
||||
|
||||
Reference in New Issue
Block a user