yorickr/plezy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(player): preserve volume when toggling mute (#1532)

Browse Source 
* fix(player): preserve volume when toggling mute

Muting now keeps the last volume level memorized. Unmuting restores that level, including amplified values allowed by the configured maximum.

* fix(player): preserve volume for companion remote mute

Route the companion remote through the shared mute transition so it no longer overwrites the persisted volume or restores to 100%. Also correct the Dartdoc formatting for the transition record fields.
This commit is contained in:
Ryan Ernest
2026-07-11 12:46:58 +02:00
committed by GitHub
parent d86e328169
commit c86d40f8dd
7 changed files with 192 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/services/keyboard_shortcuts_service.dart
+3 -3
View File
@@ -344,9 +344,9 @@ class KeyboardShortcutsService extends ChangeNotifier {
onToggleFullscreen?.call();
break;
case 'mute_toggle':
final newVolume = player.state.volume > 0 ? 0.0 : 100.0;
player.setVolume(newVolume);
_settingsService.write(SettingsService.volume, newVolume);
final transition = _settingsService.resolveMuteToggle(player.state.volume);
player.setVolume(transition.playerVolume);
_settingsService.write(SettingsService.volume, transition.persistedVolume);
break;
case 'subtitle_toggle':
onToggleSubtitles?.call();
lib/services/settings_service.dart
+15
View File
@@ -614,6 +614,21 @@ class SettingsService extends BaseSharedPreferencesService {
_cachedInstance = null;
}
/// Resolves a video mute toggle without replacing the saved volume with 0.
///
/// `persistedVolume` is the non-zero value callers should keep in [volume],
/// while `playerVolume` is the value to apply to the active player.
({double playerVolume, double persistedVolume}) resolveMuteToggle(double currentVolume) {
if (currentVolume.isFinite && currentVolume > 0) {
return (playerVolume: 0, persistedVolume: currentVolume);
}
final previousVolume = read(volume);
final candidate = previousVolume.isFinite && previousVolume > 0 ? previousVolume : volume.defaultValue;
final restoredVolume = candidate.clamp(0.0, read(maxVolume).toDouble()).toDouble();
return (playerVolume: restoredVolume, persistedVolume: restoredVolume);
}
static Map<String, String> defaultKeyboardShortcuts() => _defaultKeyboardShortcuts();
static Map<String, HotKey> defaultKeyboardHotkeys() => _defaultKeyboardHotkeys();