refactor: shared coalescer, profile-scoped prefs key, and form-error helper

2026-07-10 07:05:35 +02:00
parent 397de2698d
commit ede80d225f
9 changed files with 119 additions and 28 deletions
@@ -0,0 +1,54 @@
+import 'package:flutter_test/flutter_test.dart';
+import 'package:plezy/profiles/profile.dart';
+import 'package:plezy/services/base_shared_preferences_service.dart';
+import 'package:plezy/services/trackers/tracker_account_store.dart';
+import 'package:plezy/services/trackers/tracker_constants.dart';
+import 'package:plezy/services/trackers/tracker_session.dart';
+
+import '../../test_helpers/prefs.dart';
+
+const _fullProfileId = 'plex-home-plex.e443d57860076fc3-e443d57860076fc3';
+const _homeUserUuid = 'e443d57860076fc3';
+
+TrackerSession _session() {
+  final now = DateTime.now().millisecondsSinceEpoch ~/ 1000;
+  return TrackerSession(accessToken: 'a', refreshToken: 'r', expiresAt: now + 86400, createdAt: now);
+}
+
+void main() {
+  setUp(resetSharedPreferencesForTest);
+
+  group('profile user scoping', () {
+    test('profileUserScope reduces Plex Home ids to the bare home-user uuid', () {
+      expect(profileUserScope(_fullProfileId), _homeUserUuid);
+      expect(profileUserScope(_homeUserUuid), _homeUserUuid);
+      expect(profileUserScope('local-abc'), 'local-abc');
+    });
+
+    test('profileScopedPrefsKey normalizes full profile ids to the uuid scope', () {
+      expect(profileScopedPrefsKey(_fullProfileId, 'trakt_session'), 'user_${_homeUserUuid}_trakt_session');
+      expect(profileScopedPrefsKey(_homeUserUuid, 'trakt_session'), 'user_${_homeUserUuid}_trakt_session');
+      expect(profileScopedPrefsKey('', 'trakt_session'), 'trakt_session');
+    });
+
+    /// Regression: sessions saved under the full profile id were relocated to
+    /// the uuid scope by StorageService's launch-time repair, so the next
+    /// hydrate (same full id) missed them — Trakt "unlinked" on every
+    /// restart. Save and load must agree on the uuid scope regardless of
+    /// which id form the caller passes.
+    test('store writes the uuid-scoped key and loads it from either id form', () async {
+      final store = trackerAccountStore(TrackerService.trakt);
+      await store.save(_fullProfileId, _session());
+
+      final prefs = await BaseSharedPreferencesService.sharedCache();
+      expect(prefs.getString('user_${_homeUserUuid}_trakt_session'), isNotNull);
+      expect(prefs.getString('user_${_fullProfileId}_trakt_session'), isNull);
+
+      expect(await store.load(_fullProfileId), isNotNull);
+      expect(await store.load(_homeUserUuid), isNotNull);
+
+      await store.clear(_fullProfileId);
+      expect(await store.load(_homeUserUuid), isNull);
+    });
+  });
+}