yorickr/plezy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(livetv): explain a guide emptied by the favorites filter

Browse Source 
With "Default to Favorite Channels" enabled and no favorites stored —
or only favorites left over from a since-rebuilt lineup — the favorites
filter reduced the guide to zero channels and GuideTab rendered just
the timeline bar: no rows, no message, no sign a filter was active.
Users read it as Live TV being broken; the Aug 8 report in #887 shows
44 channels and 447 grid programs loading in the log while the
screenshot shows a blank guide and 0 favorite channels.

When the filter removes every loaded channel, the guide tab now shows
an empty state naming the cause with a "Show All Channels" action that
clears the filter. The action stays D-pad reachable: the tab-bar focus
handoff falls through to the action's focus node while the empty state
replaces GuideTab, and activating it hands focus back to the restored
guide content. Favorites that match no loaded channel get the same
treatment as an empty favorites list.

Verified: flutter test test/screens/livetv/, analyzer parity,
clean_translations --check --strict, and slang codegen freshness.

Refs #887.
This commit is contained in:
edde746
2026-08-09 11:12:08 +02:00
parent de76c0a515
commit ff461d9f71
26 changed files with 155 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/i18n/strings_en.g.dart
+14 -2
View File
@@ -3259,6 +3259,15 @@ class Translations$liveTv$en {
/// en: 'Reorder Favorites'
String get reorderFavorites => 'Reorder Favorites';
/// en: 'No favorite channels'
String get noFavoriteChannels => 'No favorite channels';
/// en: 'Show all channels, then long-press a channel to add it to your favorites.'
String get noFavoriteChannelsHint => 'Show all channels, then long-press a channel to add it to your favorites.';
/// en: 'Show All Channels'
String get showAllChannels => 'Show All Channels';
/// en: 'Could not load favorites. Check your connection and try again.'
String get favoritesLoadFailed => 'Could not load favorites. Check your connection and try again.';
@@ -7281,6 +7290,9 @@ extension on Translations {
'liveTv.watchChannel' => 'Watch Channel',
'liveTv.favorites' => 'Favorites',
'liveTv.reorderFavorites' => 'Reorder Favorites',
'liveTv.noFavoriteChannels' => 'No favorite channels',
'liveTv.noFavoriteChannelsHint' => 'Show all channels, then long-press a channel to add it to your favorites.',
'liveTv.showAllChannels' => 'Show All Channels',
'liveTv.favoritesLoadFailed' => 'Could not load favorites. Check your connection and try again.',
'liveTv.favoritesUpdateFailed' => 'Could not update favorites. Check your connection and try again.',
'liveTv.joinSession' => 'Join Session in Progress',
@@ -7667,11 +7679,11 @@ extension on Translations {
'performanceOverlay.matrix' => 'Matrix',
'performanceOverlay.primaries' => 'Primaries',
'performanceOverlay.transfer' => 'Transfer',
_ => null,
} ?? switch (path) {
'performanceOverlay.renderFps' => 'Render FPS',
'performanceOverlay.displayFps' => 'Display FPS',
'performanceOverlay.avSync' => 'A/V Sync',
_ => null,
} ?? switch (path) {
'performanceOverlay.dropped' => 'Dropped',
'performanceOverlay.dvRpus' => 'DV RPUs',
'performanceOverlay.dvRpuAverage' => 'DV RPU Avg',