Files
plezy/lib/services/fullscreen_state_manager.dart
Vincent Vallee 8879941d29 fix(player): keep app-owned fullscreen when Escape leaves the player (#1791)
Physical Escape inside the player resolved to exitFullscreenIfActive on
Windows and Linux whenever HTPC-style player navigation was off, so it dropped
the window out of fullscreen regardless of who put it there. For anyone running
with "start in fullscreen" (or who had toggled fullscreen from the browse UI),
backing out of a movie left the app windowed, with "exit fullscreen on player
close" switched off.

Track fullscreen ownership instead: FullscreenStateManager now exposes a scope
that the player opens in initState and closes in dispose, and setFullscreen —
the single funnel every desktop platform reports through (window_manager on
Linux, the Win32 runner callback on Windows, NSWindowDelegate on macOS) —
records whether the fullscreen currently active was entered inside that scope.
Escape only exits fullscreen the player itself entered; otherwise it is plain
Back. The scope is depth-counted so the next-episode swap, where the incoming
screen's initState runs before the outgoing screen's dispose, carries ownership
across rather than resetting it.

Nothing changes for a user who fullscreens from inside the player: Escape still
exits fullscreen first, then acts as Back. The fullscreen toggle button and its
shortcut are untouched, as is exitFullscreenOnPlayerClose.

Fixes #1624.
2026-08-05 07:14:11 +02:00

171 lines
5.1 KiB
Dart

import 'dart:io' show Platform;
import 'package:flutter/foundation.dart';
import 'package:window_manager/window_manager.dart';
import '../utils/platform_detector.dart';
import 'macos_window_service.dart';
import 'native_window_service.dart';
class FullscreenStateManager extends ChangeNotifier with WindowListener {
static final FullscreenStateManager _instance = FullscreenStateManager._internal();
factory FullscreenStateManager() => _instance;
FullscreenStateManager._internal();
bool _isFullscreen = false;
bool _isListening = false;
bool _wasMaximized = false;
int _scopeDepth = 0;
bool _scopeOwnsFullscreen = false;
bool get isFullscreen => _isFullscreen;
/// Whether the fullscreen currently active was entered while a scope opened
/// by [beginScope] was on screen.
///
/// Fullscreen that predates the scope belongs to the app window — the
/// "start in fullscreen" setting, or a toggle from the browse UI — and must
/// outlive the scope that happens to be open. Only fullscreen the scope
/// itself entered is the scope's to drop (edde746/plezy#1624).
bool get scopeOwnsFullscreen => _scopeOwnsFullscreen;
/// Opens a fullscreen ownership scope. Nested opens (the video player
/// replacing itself for the next episode, where the incoming screen's
/// initState runs before the outgoing screen's dispose) carry ownership
/// across the swap rather than resetting it.
void beginScope() {
_scopeDepth++;
if (_scopeDepth == 1) {
_scopeOwnsFullscreen = false;
}
}
/// Closes a scope opened by [beginScope].
void endScope() {
if (_scopeDepth == 0) return;
_scopeDepth--;
if (_scopeDepth == 0) {
_scopeOwnsFullscreen = false;
}
}
/// Manually set fullscreen state (called by NSWindowDelegate callbacks on macOS)
void setFullscreen(bool value) {
if (_isFullscreen != value) {
_isFullscreen = value;
if (_scopeDepth > 0) {
_scopeOwnsFullscreen = value;
}
notifyListeners();
}
}
/// Toggle fullscreen state, handling maximized-to-fullscreen transition on Windows/Linux
Future<void> toggleFullscreen() async {
if (!PlatformDetector.isDesktopOS()) return;
final isCurrentlyFullscreen = await _platformIsFullscreen();
await _platformSetFullscreen(!isCurrentlyFullscreen);
}
/// Enter fullscreen, preserving maximized state on Windows/Linux for restoration on exit.
Future<void> enterFullscreen() async {
if (!PlatformDetector.isDesktopOS()) return;
await _platformSetFullscreen(true);
}
/// Exit fullscreen, restoring maximized state if needed
Future<void> exitFullscreen() async {
if (!PlatformDetector.isDesktopOS()) return;
await _platformSetFullscreen(false);
}
/// Exits fullscreen when the platform window is currently fullscreen.
///
/// Returns whether fullscreen consumed the request. Querying the native
/// source avoids relying on listener state that may still be catching up.
Future<bool> exitFullscreenIfActive() async {
if (!PlatformDetector.isDesktopOS()) return false;
final isActive = await _platformIsFullscreen();
if (!isActive) return false;
await _platformSetFullscreen(false);
return true;
}
Future<bool> _platformIsFullscreen() {
if (Platform.isMacOS) return MacOSWindowService.isFullscreen();
if (Platform.isWindows) return NativeWindowService.isFullScreen();
return windowManager.isFullScreen();
}
Future<void> _platformSetFullscreen(bool value) async {
if (Platform.isMacOS) {
if (value) {
await MacOSWindowService.enterFullscreen();
} else {
await MacOSWindowService.exitFullscreen();
}
} else if (Platform.isWindows) {
// Route through the native Win32 runner, which restores to the monitor
// the window is currently on (window_manager 0.5.1 picks the wrong one
// on multi-monitor setups — see issue #880). The native code also
// preserves maximized state internally, so no unmaximize dance here.
await NativeWindowService.setFullScreen(value);
} else if (value) {
_wasMaximized = await windowManager.isMaximized();
if (_wasMaximized) {
await windowManager.unmaximize();
}
await windowManager.setFullScreen(true);
} else {
await windowManager.setFullScreen(false);
if (_wasMaximized) {
await windowManager.maximize();
_wasMaximized = false;
}
}
}
void startMonitoring() {
if (!_shouldMonitor() || _isListening) return;
// Use window_manager listener for Windows/Linux
// macOS uses NSWindowDelegate callbacks instead (see FullscreenWindowDelegate)
if (!Platform.isMacOS) {
windowManager.addListener(this);
_isListening = true;
}
}
void stopMonitoring() {
if (_isListening) {
windowManager.removeListener(this);
_isListening = false;
}
}
bool _shouldMonitor() {
return PlatformDetector.isDesktopOS();
}
@override
void onWindowEnterFullScreen() {
setFullscreen(true);
}
@override
void onWindowLeaveFullScreen() {
setFullscreen(false);
}
@override
void dispose() {
stopMonitoring();
super.dispose();
}
}