Files
plezy/test/services/jellyfin_display_metadata_test.dart
edde746 05fd622968 feat(emby): add Emby as a MediaBrowser backend alongside Jellyfin
Emby is Jellyfin's upstream ancestor and speaks a near-identical MediaBrowser
API, so the existing Jellyfin stack is parameterised by a `MediaBrowserDialect`
rather than forked. `JellyfinClient`, its auth service, endpoint discovery, LAN
discovery, and the add/edit connection screens all take the dialect and keep one
implementation; `MediaBackend.emby` and `ConnectionKind.emby` carry it through
the neutral models, the Drift `kind` discriminator, downloads, and caches.

Every divergence below was measured against a live Emby 4.9.5 server, not
inferred from documentation, and each is documented at its capability getter.
Jellyfin's request strings stay byte-identical so nothing about its behaviour
changes.

Routes and auth
- Emby only accepts the pre-10.9 user-scoped item routes (`/Users/{id}/Items/…`,
  `/Users/{id}/PlayedItems/…`, `/Users/{id}/FavoriteItems/…`); the unprefixed
  forms Jellyfin 10.11 added return 404.
- The API is also served under a legacy `/emby` prefix, and both dialects accept
  the token as `X-Emby-Token` or `api_key=`.
- Emby answers only its own LAN discovery datagram ("who is EmbyServer?") and
  ignores Jellyfin's; its default HTTPS port is 8920.
- No `/QuickConnect` route exists, so Quick Connect stays Jellyfin-only.

Row fields Emby withholds
- `ProductionYear`, `OfficialRating`, `PremiereDate` and `DateCreated` are absent
  from list rows unless named in `Fields`, which would otherwise strip the year
  and age-rating badge from every card in the app.
- `UserData.LastPlayedDate` never appears on a list row under `Fields=UserData`,
  `EnableUserData=true` or the user-scoped `Ids=` form — only on the single-item
  detail route, or when the Emby-specific `UserDataLastPlayedDate` token is
  requested. Without it every recency-ordered surface silently degrades to
  library-add time, and `JellyfinApiCache.applyWatchState` stamps
  `DateTime.now()` on watched rows, so an offline watch-state pull would rewrite
  the cached play time of everything it walked.

Continue Watching and Next Up
- Emby computes Next Up per series only: the library-wide `/Shows/NextUp` query
  returns nothing under every parameter combination tried. The shelf is
  therefore reconstructed from a played-episode recency scan plus one
  `/Shows/NextUp?SeriesId=` per distinct series, bounded by a shared wall clock
  that covers the scan as well — per-request timeouts cannot bound the pass
  because `MediaServerHttpClient` times the connect and receive phases
  independently. Rows are stamped with their series' newest play from the same
  response that ordered them, so no per-series enrichment request is needed.
- `/Shows/NextUp` ignores `NextUpDateCutoff`, and no server-side played-date
  filter exists to delegate to (`MinDatePlayed` and `MinDateLastPlayed` are
  ignored; `MinDateLastSaved`, `MinDateCreated` and `MinPremiereDate` filter
  unrelated dates), so the 365-day window is applied to the scanned dates.
- The resume route returns items with no saved position, including plain next
  episodes, so the Emby resume leg reads from `/Items?Filters=IsResumable`.
- Emby is ahead of Jellyfin in one place: `/Users/{id}/Items/{id}/HideFromResume`
  makes Continue Watching removal a real capability.

Everything else
- `/Sessions/Playing` and `/Sessions/Playing/Progress` reject a body with no
  `PlaySessionId` (HTTP 400), so playback reporting always sends one.
- Passing any `MediaTypes` value to the playlist query returns an empty list.
- There is no aggregate `/Items/Filters` route; the four filter facets are
  reassembled from `/Genres`, `/OfficialRatings`, `/Studios` and `/Tags`.
- Metadata writes take name-pair lists (`Genres: [{'Name': 'Action'}]`); the
  plain string array is accepted and then silently discarded.
- Custom artwork uploads must be base64 text, not raw bytes — which was broken
  for Jellyfin too and is fixed for both.
- Trickplay, media segments and lyrics 404 on Emby, so scrub previews are absent
  and intro/credit markers fall back to chapter names.

Verified against a local Emby 4.9.5 and a Jellyfin 10.11.11 control server:
onboarding, browse, detail, playable stream URLs serving real bytes, subtitle
sidecars, watch-state write and restore, hubs, cross-server aggregation and
search across both backends simultaneously.
2026-08-05 06:09:26 +02:00

100 lines
3.5 KiB
Dart

import 'package:flutter_test/flutter_test.dart';
import 'package:plezy/services/jellyfin_display_metadata.dart';
/// HDR/Dolby Vision classification from a MediaBrowser `MediaStreams[]` entry.
///
/// The fixtures are verbatim video-stream shapes captured from Jellyfin 10.11
/// and Emby 4.9.5 for the same HDR10 HEVC file. They differ: Jellyfin sends
/// `VideoRangeType`, Emby does not — it sends `VideoRange: 'HDR 10'` plus its
/// own `ExtendedVideoType`. Detection must not depend on the Jellyfin-only
/// field, which is why both shapes are pinned here.
void main() {
group('HDR detection across MediaBrowser dialects', () {
// Emby 4.9.5, HDR10 HEVC. Note the absent VideoRangeType.
const embyHdr10 = <String, dynamic>{
'Type': 'Video',
'Codec': 'hevc',
'Profile': 'Main 10',
'BitDepth': 10,
'VideoRange': 'HDR 10',
'ColorTransfer': 'smpte2084',
'ColorPrimaries': 'bt2020',
'ColorSpace': 'bt2020nc',
'ExtendedVideoType': 'Hdr10',
'Width': 640,
'Height': 360,
'AverageFrameRate': 24,
};
// Jellyfin 10.11 shape for the same content.
const jellyfinHdr10 = <String, dynamic>{
'Type': 'Video',
'Codec': 'hevc',
'Profile': 'Main 10',
'BitDepth': 10,
'VideoRange': 'HDR',
'VideoRangeType': 'HDR10',
'ColorTransfer': 'smpte2084',
'ColorPrimaries': 'bt2020',
'ColorSpace': 'bt2020nc',
'Width': 640,
'Height': 360,
'AverageFrameRate': 24,
};
const sdr = <String, dynamic>{
'Type': 'Video',
'Codec': 'h264',
'VideoRange': 'SDR',
'Width': 640,
'Height': 360,
'AverageFrameRate': 24,
};
test('Emby HDR10 is detected without the Jellyfin-only VideoRangeType', () {
expect(embyHdr10.containsKey('VideoRangeType'), isFalse, reason: 'fixture must reflect the real Emby shape');
expect(jellyfinVideoStreamIsHdr(const {}, embyHdr10), isTrue);
final criteria = jellyfinDisplayCriteriaFromStream(const {}, embyHdr10);
expect(criteria, isNotNull);
expect(criteria!.isHdr, isTrue);
expect(criteria.transfer, 'smpte2084');
expect(criteria.primaries, 'bt2020');
});
test('Jellyfin HDR10 is detected from its own field set', () {
expect(jellyfinVideoStreamIsHdr(const {}, jellyfinHdr10), isTrue);
expect(jellyfinDisplayCriteriaFromStream(const {}, jellyfinHdr10)!.isHdr, isTrue);
});
test('an SDR stream is not misreported as HDR on either dialect', () {
expect(jellyfinVideoStreamIsHdr(const {}, sdr), isFalse);
expect(jellyfinVideoStreamIsHdr(const {}, {...sdr, 'VideoRangeType': 'SDR'}), isFalse);
});
test('Dolby Vision is detected from the Dv* fields both dialects share', () {
const dovi = <String, dynamic>{
'Type': 'Video',
'Codec': 'hevc',
'VideoRange': 'HDR',
'DvProfile': 8,
'DvBlSignalCompatibilityId': 1,
'DvVersionMajor': 1,
'Width': 3840,
'Height': 2160,
};
expect(jellyfinVideoStreamIsDolbyVision(dovi), isTrue);
expect(jellyfinDolbyVisionProfile(dovi), 8);
expect(jellyfinVideoStreamIsHdr(const {}, dovi), isTrue);
});
test('a stream carrying no range signal at all is treated as SDR, not unknown', () {
const bare = <String, dynamic>{'Type': 'Video', 'Codec': 'h264', 'Width': 1920, 'Height': 1080};
expect(jellyfinVideoStreamIsHdr(const {}, bare), isFalse);
expect(jellyfinVideoStreamIsDolbyVision(bare), isFalse);
});
});
}