Files
plezy/lib/screens/settings/edit_jellyfin_connection_screen.dart
T
edde746 05fd622968 feat(emby): add Emby as a MediaBrowser backend alongside Jellyfin
Emby is Jellyfin's upstream ancestor and speaks a near-identical MediaBrowser
API, so the existing Jellyfin stack is parameterised by a `MediaBrowserDialect`
rather than forked. `JellyfinClient`, its auth service, endpoint discovery, LAN
discovery, and the add/edit connection screens all take the dialect and keep one
implementation; `MediaBackend.emby` and `ConnectionKind.emby` carry it through
the neutral models, the Drift `kind` discriminator, downloads, and caches.

Every divergence below was measured against a live Emby 4.9.5 server, not
inferred from documentation, and each is documented at its capability getter.
Jellyfin's request strings stay byte-identical so nothing about its behaviour
changes.

Routes and auth
- Emby only accepts the pre-10.9 user-scoped item routes (`/Users/{id}/Items/…`,
  `/Users/{id}/PlayedItems/…`, `/Users/{id}/FavoriteItems/…`); the unprefixed
  forms Jellyfin 10.11 added return 404.
- The API is also served under a legacy `/emby` prefix, and both dialects accept
  the token as `X-Emby-Token` or `api_key=`.
- Emby answers only its own LAN discovery datagram ("who is EmbyServer?") and
  ignores Jellyfin's; its default HTTPS port is 8920.
- No `/QuickConnect` route exists, so Quick Connect stays Jellyfin-only.

Row fields Emby withholds
- `ProductionYear`, `OfficialRating`, `PremiereDate` and `DateCreated` are absent
  from list rows unless named in `Fields`, which would otherwise strip the year
  and age-rating badge from every card in the app.
- `UserData.LastPlayedDate` never appears on a list row under `Fields=UserData`,
  `EnableUserData=true` or the user-scoped `Ids=` form — only on the single-item
  detail route, or when the Emby-specific `UserDataLastPlayedDate` token is
  requested. Without it every recency-ordered surface silently degrades to
  library-add time, and `JellyfinApiCache.applyWatchState` stamps
  `DateTime.now()` on watched rows, so an offline watch-state pull would rewrite
  the cached play time of everything it walked.

Continue Watching and Next Up
- Emby computes Next Up per series only: the library-wide `/Shows/NextUp` query
  returns nothing under every parameter combination tried. The shelf is
  therefore reconstructed from a played-episode recency scan plus one
  `/Shows/NextUp?SeriesId=` per distinct series, bounded by a shared wall clock
  that covers the scan as well — per-request timeouts cannot bound the pass
  because `MediaServerHttpClient` times the connect and receive phases
  independently. Rows are stamped with their series' newest play from the same
  response that ordered them, so no per-series enrichment request is needed.
- `/Shows/NextUp` ignores `NextUpDateCutoff`, and no server-side played-date
  filter exists to delegate to (`MinDatePlayed` and `MinDateLastPlayed` are
  ignored; `MinDateLastSaved`, `MinDateCreated` and `MinPremiereDate` filter
  unrelated dates), so the 365-day window is applied to the scanned dates.
- The resume route returns items with no saved position, including plain next
  episodes, so the Emby resume leg reads from `/Items?Filters=IsResumable`.
- Emby is ahead of Jellyfin in one place: `/Users/{id}/Items/{id}/HideFromResume`
  makes Continue Watching removal a real capability.

Everything else
- `/Sessions/Playing` and `/Sessions/Playing/Progress` reject a body with no
  `PlaySessionId` (HTTP 400), so playback reporting always sends one.
- Passing any `MediaTypes` value to the playlist query returns an empty list.
- There is no aggregate `/Items/Filters` route; the four filter facets are
  reassembled from `/Genres`, `/OfficialRatings`, `/Studios` and `/Tags`.
- Metadata writes take name-pair lists (`Genres: [{'Name': 'Action'}]`); the
  plain string array is accepted and then silently discarded.
- Custom artwork uploads must be base64 text, not raw bytes — which was broken
  for Jellyfin too and is fixed for both.
- Trickplay, media segments and lyrics 404 on Emby, so scrub previews are absent
  and intro/credit markers fall back to chapter names.

Verified against a local Emby 4.9.5 and a Jellyfin 10.11.11 control server:
onboarding, browse, detail, playable stream URLs serving real bytes, subtitle
sidecars, watch-state write and restore, hubs, cross-server aggregation and
search across both backends simultaneously.
2026-08-05 06:09:26 +02:00

135 lines
5.2 KiB
Dart

import 'package:flutter/material.dart';
import 'package:material_symbols_icons/symbols.dart';
import 'package:provider/provider.dart';
import '../../connection/connection.dart';
import '../../connection/connection_registry.dart';
import '../../exceptions/media_server_exceptions.dart';
import '../../focus/focusable_button.dart';
import '../../focus/focusable_text_field.dart';
import '../../i18n/strings.g.dart';
import '../../mixins/controller_disposer_mixin.dart';
import '../../services/jellyfin_endpoint_discovery.dart';
import '../../utils/app_logger.dart';
import '../../widgets/app_icon.dart';
import '../../widgets/focused_scroll_scaffold.dart';
import '../../widgets/loading_indicator_box.dart';
import 'async_form_state_mixin.dart';
class EditJellyfinConnectionScreen extends StatefulWidget {
final JellyfinConnection connection;
const EditJellyfinConnectionScreen({super.key, required this.connection});
@override
State<EditJellyfinConnectionScreen> createState() => _EditJellyfinConnectionScreenState();
}
class _EditJellyfinConnectionScreenState extends State<EditJellyfinConnectionScreen>
with AsyncFormStateMixin, ControllerDisposerMixin {
late final _urlsController = createTextEditingController(text: widget.connection.baseUrls.join('\n'));
final _urlsFocus = FocusNode(debugLabel: 'EditJellyfin:Urls');
final _saveFocus = FocusNode(debugLabel: 'EditJellyfin:Save');
final _formKey = GlobalKey<FormState>();
@override
void dispose() {
_urlsFocus.dispose();
_saveFocus.dispose();
super.dispose();
}
Future<void> _save() async {
if (!(_formKey.currentState?.validate() ?? false)) return;
await runAsync<void>(
() async {
final input = JellyfinEndpointDiscovery.buildUserInputCandidates(
_enteredUrls(),
dialect: widget.connection.dialect,
);
final endpoint = await JellyfinEndpointDiscovery(dialect: widget.connection.dialect).raceEndpoints(
input.probeBaseUrls,
preferredUrl: widget.connection.baseUrl,
expectedMachineId: widget.connection.serverMachineId,
baseUrlsToPersist: input.explicitBaseUrls,
baseUrlValidationGroups: input.validationBaseUrlGroups,
);
final updated = widget.connection.copyWith(
baseUrl: endpoint.activeBaseUrl,
baseUrls: endpoint.baseUrls,
serverName: endpoint.serverInfo.serverName,
);
if (!mounted) return;
await context.read<ConnectionRegistry>().upsert(updated);
if (!mounted) return;
Navigator.of(context).pop(true);
},
errorMapper: (e) {
if (e is MediaServerUrlException) return e.message;
appLogger.e('Edit ${widget.connection.dialect.productName} connection failed', error: e);
return t.addServer.couldNotReachServer(error: e.toString());
},
);
}
List<String> _enteredUrls() => JellyfinEndpointDiscovery.parseUserEnteredUrls(_urlsController.text);
@override
Widget build(BuildContext context) {
final theme = Theme.of(context);
return FocusedScrollScaffold(
title: Text(t.connections.editMediaBrowserTitle(product: widget.connection.dialect.productName)),
slivers: [
SliverPadding(
padding: const EdgeInsets.all(16),
sliver: SliverToBoxAdapter(
child: Form(
key: _formKey,
child: Column(
crossAxisAlignment: .stretch,
children: [
Text(
t.connections.editMediaBrowserIntro(serverName: widget.connection.serverName),
style: theme.textTheme.bodyMedium,
),
const SizedBox(height: 16),
FocusableTextFormField(
controller: _urlsController,
focusNode: _urlsFocus,
tvTextInputPresentation: TvTextInputPresentation.flutterOverlay,
autofocus: true,
keyboardType: TextInputType.url,
minLines: 1,
maxLines: 5,
autocorrect: false,
enableSuggestions: false,
enabled: !busy,
onNavigateDown: () => _saveFocus.requestFocus(),
decoration: InputDecoration(
labelText: t.addServer.serverUrls,
prefixIcon: const AppIcon(Symbols.link_rounded, fill: 1),
),
validator: (_) => _enteredUrls().isEmpty ? t.addServer.required : null,
),
const SizedBox(height: 16),
FocusableButton(
focusNode: _saveFocus,
useBackgroundFocus: true,
onPressed: busy ? null : _save,
child: FilledButton.icon(
onPressed: busy ? null : _save,
icon: busy ? const LoadingIndicatorBox() : const AppIcon(Symbols.save_rounded, fill: 1),
label: Text(t.common.save),
),
),
...buildInlineError(theme),
],
),
),
),
),
],
);
}
}