Files
plezy/shared/mpv/mpv_player_common.h
T
edde746 a56b9a3dfb Merge the deduplication and dead-code removal pass
Consolidates duplicated logic behind shared implementations — paginated
grid tabs, focus chrome, cached remote stores, sheet selection columns,
the server artifact store and a test fixture layer — and removes code
that had become unreachable. Net reduction of about 5,500 lines with no
behaviour change.

Where a fix had landed separately in code that moved into a shared
helper, the fix was re-applied inside the helper rather than left behind
in the copy that went away.
2026-07-26 19:41:23 +02:00

557 lines
20 KiB
C++

#ifndef PLEZY_SHARED_MPV_PLAYER_COMMON_H_
#define PLEZY_SHARED_MPV_PLAYER_COMMON_H_
#include <mpv/client.h>
#include <algorithm>
#include <atomic>
#include <chrono>
#include <cstdint>
#include <cstring>
#include <functional>
#include <map>
#include <mutex>
#include <string>
#include <utility>
#include <vector>
namespace plezy {
namespace mpv_common {
using StatusCallback = std::function<void(int error)>;
using GetPropertyCallback = std::function<void(int error, const std::string& value)>;
static constexpr char kSetPropertyFailedCode[] = "SET_PROPERTY_FAILED";
static constexpr char kSetPropertyNotInitializedCode[] = "NOT_INITIALIZED";
static constexpr size_t kSetPropertyErrorDescriptionLimit = 160;
inline bool SetPropertyStatusSucceeded(int status) { return status >= 0; }
inline const char* SetPropertyErrorCode(int status) {
return status == MPV_ERROR_UNINITIALIZED ? kSetPropertyNotInitializedCode : kSetPropertyFailedCode;
}
inline std::string SetPropertyErrorDescription(int status) {
const char* description = mpv_error_string(status);
if (!description || description[0] == '\0') {
return "MPV property write failed";
}
size_t length = 0;
while (length < kSetPropertyErrorDescriptionLimit && description[length] != '\0') {
++length;
}
return std::string(description, length);
}
struct CancelledRequests {
std::vector<StatusCallback> status;
std::vector<GetPropertyCallback> properties;
};
class AsyncRequestRegistry {
public:
uint64_t RegisterStatus(StatusCallback callback) {
std::lock_guard<std::mutex> lock(mutex_);
const uint64_t request_id = next_id_++;
status_[request_id] = std::move(callback);
return request_id;
}
StatusCallback TakeStatus(uint64_t request_id) {
std::lock_guard<std::mutex> lock(mutex_);
auto it = status_.find(request_id);
if (it == status_.end()) return nullptr;
auto callback = std::move(it->second);
status_.erase(it);
return callback;
}
uint64_t RegisterProperty(GetPropertyCallback callback) {
std::lock_guard<std::mutex> lock(mutex_);
const uint64_t request_id = next_id_++;
properties_[request_id] = std::move(callback);
return request_id;
}
GetPropertyCallback TakeProperty(uint64_t request_id) {
std::lock_guard<std::mutex> lock(mutex_);
auto it = properties_.find(request_id);
if (it == properties_.end()) return nullptr;
auto callback = std::move(it->second);
properties_.erase(it);
return callback;
}
CancelledRequests CancelAll() {
CancelledRequests cancelled;
std::lock_guard<std::mutex> lock(mutex_);
cancelled.status.reserve(status_.size());
for (auto& request : status_) {
if (request.second) {
cancelled.status.push_back(std::move(request.second));
}
}
cancelled.properties.reserve(properties_.size());
for (auto& request : properties_) {
if (request.second) {
cancelled.properties.push_back(std::move(request.second));
}
}
status_.clear();
properties_.clear();
return cancelled;
}
private:
uint64_t next_id_ = 1;
std::map<uint64_t, StatusCallback> status_;
std::map<uint64_t, GetPropertyCallback> properties_;
std::mutex mutex_;
};
// Every libmpv async submission follows the same shape: register the callback,
// hand the request to mpv, and roll back when the submission fails. A negative
// result means the request never reached mpv, so nothing will ever complete it
// and the callback has to be taken back and failed inline. The uninitialized
// handle guard stays with the callers: they own the lifecycle flags and the
// error code they report when the handle is gone.
inline void SubmitCommandAsync(
mpv_handle* mpv, AsyncRequestRegistry& requests, const std::vector<std::string>& args, StatusCallback callback) {
std::vector<const char*> c_args;
c_args.reserve(args.size() + 1);
for (const auto& arg : args) {
c_args.push_back(arg.c_str());
}
c_args.push_back(nullptr);
const uint64_t request_id = callback ? requests.RegisterStatus(std::move(callback)) : 0;
// mpv_command_async returns immediately.
const int result = mpv_command_async(mpv, request_id, c_args.data());
if (result < 0) {
auto pending = requests.TakeStatus(request_id);
if (pending) pending(result);
}
}
inline void SubmitSetPropertyAsync(
mpv_handle* mpv, AsyncRequestRegistry& requests, const std::string& name, const std::string& value,
StatusCallback callback) {
const uint64_t request_id = callback ? requests.RegisterStatus(std::move(callback)) : 0;
char* property_value = const_cast<char*>(value.c_str());
const int result = mpv_set_property_async(mpv, request_id, name.c_str(), MPV_FORMAT_STRING, &property_value);
if (result < 0) {
auto pending = requests.TakeStatus(request_id);
if (pending) pending(result);
}
}
inline void SubmitGetPropertyAsync(
mpv_handle* mpv, AsyncRequestRegistry& requests, const std::string& name, GetPropertyCallback callback) {
const uint64_t request_id = requests.RegisterProperty(std::move(callback));
const int result = mpv_get_property_async(mpv, request_id, name.c_str(), MPV_FORMAT_STRING);
if (result < 0) {
auto pending = requests.TakeProperty(request_id);
if (pending) pending(result, "");
}
}
// Completes a COMMAND_REPLY / SET_PROPERTY_REPLY / GET_PROPERTY_REPLY against
// the pending-request registry. `sanitize` converts mpv's payload (not
// guaranteed to be valid UTF-8) into the string handed to the callback.
// Returns true when the event was a reply event and has been fully handled.
template <typename Sanitizer>
inline bool DispatchReplyEvent(AsyncRequestRegistry& requests, const mpv_event* event, const Sanitizer& sanitize) {
switch (event->event_id) {
case MPV_EVENT_COMMAND_REPLY:
case MPV_EVENT_SET_PROPERTY_REPLY: {
StatusCallback callback = requests.TakeStatus(event->reply_userdata);
if (callback) {
callback(event->error);
}
return true;
}
case MPV_EVENT_GET_PROPERTY_REPLY: {
GetPropertyCallback callback = requests.TakeProperty(event->reply_userdata);
if (callback) {
std::string value;
if (event->error >= 0) {
auto* prop = static_cast<mpv_event_property*>(event->data);
if (prop && prop->format == MPV_FORMAT_STRING && prop->data) {
auto c_value = *static_cast<char**>(prop->data);
if (c_value) value = sanitize(c_value);
}
}
callback(event->error, value);
}
return true;
}
default:
return false;
}
}
// Copies a PROPERTY_CHANGE payload into a node the platform marshallers can
// convert. mpv owns the storage, so the node only borrows it for the lifetime
// of the event.
inline mpv_node ExtractPropertyNode(const mpv_event_property* prop) {
mpv_node node{};
node.format = prop ? prop->format : MPV_FORMAT_NONE;
if (!prop) return node;
switch (prop->format) {
case MPV_FORMAT_STRING:
node.u.string = prop->data ? *static_cast<char**>(prop->data) : nullptr;
break;
case MPV_FORMAT_FLAG:
node.u.flag = prop->data ? *static_cast<int*>(prop->data) : 0;
break;
case MPV_FORMAT_INT64:
node.u.int64 = prop->data ? *static_cast<int64_t*>(prop->data) : 0;
break;
case MPV_FORMAT_DOUBLE:
node.u.double_ = prop->data ? *static_cast<double*>(prop->data) : 0.0;
break;
case MPV_FORMAT_NODE:
if (prop->data) {
node = *static_cast<mpv_node*>(prop->data);
} else {
node.format = MPV_FORMAT_NONE;
}
break;
default:
node.format = MPV_FORMAT_NONE;
break;
}
return node;
}
// mpv node payloads are untrusted input: a property can nest arbitrarily
// deeply, carry a list as long as mpv claims, and hold strings that are
// neither length-bounded nor valid UTF-8. Every runner walks the same trees
// into its own Flutter value type, so the walk and its bounds live here once.
static constexpr size_t kMaxNodeDepth = 32;
static constexpr int kMaxNodeEntries = 16384;
struct NodeConversionBudget {
size_t remaining_entries = static_cast<size_t>(kMaxNodeEntries);
size_t remaining_bytes = 16 * 1024 * 1024;
};
// Measures an mpv string without ever reading past the remaining byte budget,
// and charges it to that budget. Returns false for a missing string or one
// that would exceed what is left, which is how the walk rejects a payload.
inline bool ClaimNodeString(const char* input, NodeConversionBudget* budget, size_t* length) {
if (!input || !budget || !length) return false;
const size_t measured = strnlen(input, budget->remaining_bytes + 1);
if (measured > budget->remaining_bytes) return false;
budget->remaining_bytes -= measured;
*length = measured;
return true;
}
// `Builder` adapts the walk to a platform value type and keeps that platform's
// UTF-8 sanitizer out of this header. It supplies the types `Value`,
// `ListBuilder` and `MapBuilder`, the leaves `Null`, `Bool`, `Int`, `Double`
// and `String(data, length)`, and the containers `NewList`/`Append`/
// `FinishList` plus `NewMap`/`Insert`/`FinishMap`. A value passed to
// `Append`/`Insert` belongs to the builder from then on, and `AbandonMap`
// releases a partially built map whose key was rejected.
template <typename Builder>
typename Builder::Value ConvertNode(const mpv_node* node, size_t depth, NodeConversionBudget* budget) {
if (!node || !budget || depth >= kMaxNodeDepth || budget->remaining_entries == 0) {
return Builder::Null();
}
--budget->remaining_entries;
switch (node->format) {
case MPV_FORMAT_STRING: {
size_t length = 0;
if (!ClaimNodeString(node->u.string, budget, &length)) return Builder::Null();
return Builder::String(node->u.string, length);
}
case MPV_FORMAT_FLAG:
return Builder::Bool(node->u.flag != 0);
case MPV_FORMAT_INT64:
return Builder::Int(node->u.int64);
case MPV_FORMAT_DOUBLE:
return Builder::Double(node->u.double_);
case MPV_FORMAT_NODE_ARRAY: {
const mpv_node_list* list = node->u.list;
if (!list || list->num < 0 || list->num > kMaxNodeEntries || (list->num > 0 && !list->values)) {
return Builder::Null();
}
typename Builder::ListBuilder result = Builder::NewList();
for (int i = 0; i < list->num; i++) {
Builder::Append(result, ConvertNode<Builder>(&list->values[i], depth + 1, budget));
}
return Builder::FinishList(std::move(result));
}
case MPV_FORMAT_NODE_MAP: {
const mpv_node_list* map = node->u.list;
if (!map || map->num < 0 || map->num > kMaxNodeEntries || (map->num > 0 && (!map->keys || !map->values))) {
return Builder::Null();
}
typename Builder::MapBuilder result = Builder::NewMap();
for (int i = 0; i < map->num; i++) {
size_t key_length = 0;
if (!ClaimNodeString(map->keys[i], budget, &key_length)) {
Builder::AbandonMap(result);
return Builder::Null();
}
Builder::Insert(result, map->keys[i], key_length, ConvertNode<Builder>(&map->values[i], depth + 1, budget));
}
return Builder::FinishMap(std::move(result));
}
default:
return Builder::Null();
}
}
template <typename Builder>
typename Builder::Value ConvertNode(const mpv_node* node) {
NodeConversionBudget budget;
return ConvertNode<Builder>(node, 0, &budget);
}
inline mpv_format ParsePropertyFormat(const std::string& format) {
if (format == "string") return MPV_FORMAT_STRING;
if (format == "flag" || format == "bool") return MPV_FORMAT_FLAG;
if (format == "int64") return MPV_FORMAT_INT64;
if (format == "double") return MPV_FORMAT_DOUBLE;
if (format == "node") return MPV_FORMAT_NODE;
return MPV_FORMAT_NONE;
}
struct ObservationRequest {
bool added;
uint64_t userdata;
mpv_format format;
};
class PropertyObservationRegistry {
public:
ObservationRequest Register(const std::string& name, const std::string& format, int id) {
const mpv_format parsed_format = ParsePropertyFormat(format);
std::lock_guard<std::mutex> lock(mutex_);
if (userdata_by_name_.find(name) != userdata_by_name_.end()) {
return {false, 0, MPV_FORMAT_NONE};
}
const uint64_t userdata = next_userdata_++;
userdata_by_name_[name] = userdata;
id_by_name_[name] = id;
return {true, userdata, parsed_format};
}
bool LookupId(const std::string& name, int* id) const {
std::lock_guard<std::mutex> lock(mutex_);
const auto it = id_by_name_.find(name);
if (it == id_by_name_.end()) return false;
*id = it->second;
return true;
}
void Clear() {
std::lock_guard<std::mutex> lock(mutex_);
userdata_by_name_.clear();
id_by_name_.clear();
}
private:
uint64_t next_userdata_ = 1;
std::map<std::string, uint64_t> userdata_by_name_;
std::map<std::string, int> id_by_name_;
mutable std::mutex mutex_;
};
inline bool ParseEnabledFlag(const std::string& value) { return value == "yes" || value == "true" || value == "1"; }
inline const char* TargetColorspaceHint(bool hdr_enabled) { return hdr_enabled ? "auto" : "no"; }
enum class AudioReloadReason { kNone, kResume, kNullFallback };
struct AudioReloadAction {
AudioReloadReason reason = AudioReloadReason::kNone;
int attempt = 0;
bool exhausted = false;
uint64_t request_generation = 0;
};
enum class AudioOutputTransition { kNone, kFellBackToNull, kRecovered };
class AudioRecoveryState {
public:
using Clock = std::chrono::steady_clock;
void SetFileLoaded(bool loaded, Clock::time_point now = Clock::now()) {
std::lock_guard<std::mutex> lock(mutex_);
const bool was_loaded = file_loaded_;
file_loaded_ = loaded;
if (!loaded) {
resume_requested_ = false;
resume_attempts_left_ = 0;
null_attempts_left_ = 0;
reload_pending_ = false;
pending_request_generation_ = 0;
return;
}
if (!was_loaded && current_ao_is_null_) {
null_attempts_left_ = kNullRetryBudget;
null_backoff_ = NullFirstDelay();
null_next_attempt_ = now + NullFirstDelay();
}
}
void RequestResume() {
std::lock_guard<std::mutex> lock(mutex_);
if (!file_loaded_) {
resume_requested_ = false;
resume_attempts_left_ = 0;
return;
}
resume_requested_ = true;
}
AudioOutputTransition SetCurrentAudioOutputNull(bool is_null, Clock::time_point now) {
std::lock_guard<std::mutex> lock(mutex_);
if (is_null == current_ao_is_null_) return AudioOutputTransition::kNone;
current_ao_is_null_ = is_null;
if (is_null) {
if (file_loaded_) {
null_attempts_left_ = kNullRetryBudget;
null_backoff_ = NullFirstDelay();
null_next_attempt_ = now + NullFirstDelay();
}
return AudioOutputTransition::kFellBackToNull;
}
null_attempts_left_ = 0;
return AudioOutputTransition::kRecovered;
}
bool OnAudioDeviceListChanged(Clock::time_point now) {
std::lock_guard<std::mutex> lock(mutex_);
if (!file_loaded_ || !current_ao_is_null_) return false;
const auto candidate = now + DeviceListDebounce();
if (null_attempts_left_ <= 0 || candidate < null_next_attempt_) {
null_next_attempt_ = candidate;
}
null_attempts_left_ = kNullRetryBudget;
null_backoff_ = NullFirstDelay();
return true;
}
AudioReloadAction NextReload(Clock::time_point now) {
std::lock_guard<std::mutex> lock(mutex_);
if (resume_requested_ && file_loaded_) {
resume_requested_ = false;
resume_attempts_left_ = kResumeReloadAttempts;
resume_next_attempt_ = now + ResumeFirstDelay();
}
if (reload_pending_) return {};
if (resume_attempts_left_ > 0 && now >= resume_next_attempt_) {
const int attempt = kResumeReloadAttempts - resume_attempts_left_ + 1;
--resume_attempts_left_;
resume_next_attempt_ = now + ResumeRetryDelay();
reload_pending_ = true;
pending_request_generation_ = ++next_request_generation_;
return {AudioReloadReason::kResume, attempt, false, pending_request_generation_};
}
if (null_attempts_left_ > 0 && now >= null_next_attempt_) {
if (!current_ao_is_null_) {
null_attempts_left_ = 0;
return {};
}
const int attempt = kNullRetryBudget - null_attempts_left_ + 1;
--null_attempts_left_;
null_next_attempt_ = now + null_backoff_;
null_backoff_ = std::min(null_backoff_ * 2, NullBackoffCap());
reload_pending_ = true;
pending_request_generation_ = ++next_request_generation_;
return {AudioReloadReason::kNullFallback, attempt, null_attempts_left_ == 0, pending_request_generation_};
}
return {};
}
bool CompleteReload(uint64_t request_generation) {
std::lock_guard<std::mutex> lock(mutex_);
if (!reload_pending_ || pending_request_generation_ != request_generation) {
return false;
}
reload_pending_ = false;
pending_request_generation_ = 0;
return true;
}
bool HasPendingWork() const {
std::lock_guard<std::mutex> lock(mutex_);
return file_loaded_ &&
(resume_requested_ || resume_attempts_left_ > 0 || null_attempts_left_ > 0 || reload_pending_);
}
private:
static constexpr int kResumeReloadAttempts = 2;
static constexpr int kNullRetryBudget = 5;
static std::chrono::milliseconds ResumeFirstDelay() { return std::chrono::milliseconds(1500); }
static std::chrono::milliseconds ResumeRetryDelay() { return std::chrono::milliseconds(4500); }
static std::chrono::milliseconds NullFirstDelay() { return std::chrono::milliseconds(500); }
static std::chrono::milliseconds NullBackoffCap() { return std::chrono::milliseconds(8000); }
static std::chrono::milliseconds DeviceListDebounce() { return std::chrono::milliseconds(250); }
bool resume_requested_ = false;
bool file_loaded_ = false;
bool current_ao_is_null_ = false;
bool reload_pending_ = false;
uint64_t next_request_generation_ = 0;
uint64_t pending_request_generation_ = 0;
int resume_attempts_left_ = 0;
Clock::time_point resume_next_attempt_{};
int null_attempts_left_ = 0;
Clock::time_point null_next_attempt_{};
std::chrono::milliseconds null_backoff_{0};
mutable std::mutex mutex_;
};
struct AudioRecoveryNotice {
// What to log, or nullptr when the property changed nothing of interest.
const char* message = nullptr;
// True when the state machine now has a reload queued, which platforms that
// drive recovery from a timer rather than an event-loop tick must wake for.
bool scheduled_work = false;
};
// Feeds the audio-related properties of a PROPERTY_CHANGE event into the
// recovery state machine, leaving the caller only the platform reporting.
inline AudioRecoveryNotice ObserveAudioRecoveryProperty(
AudioRecoveryState& state, const mpv_event* event, const mpv_event_property* prop) {
if (!event || !prop || !prop->name) return {};
if (std::strcmp(prop->name, "current-ao") == 0) {
const char* current_ao = nullptr;
if (prop->format == MPV_FORMAT_STRING && prop->data) {
current_ao = *static_cast<char**>(prop->data);
}
const bool is_null = current_ao && std::strcmp(current_ao, "null") == 0;
const auto transition = state.SetCurrentAudioOutputNull(is_null, AudioRecoveryState::Clock::now());
if (transition == AudioOutputTransition::kFellBackToNull) {
return {"current-ao fell back to null; starting recovery", true};
}
if (transition == AudioOutputTransition::kRecovered) {
return {"audio recovered (current-ao no longer null)", false};
}
return {};
}
if (std::strcmp(prop->name, "audio-device-list") == 0 && event->reply_userdata == 0 &&
state.OnAudioDeviceListChanged(AudioRecoveryState::Clock::now())) {
return {"audio-device-list changed while ao=null; rescheduling ao-reload", true};
}
return {};
}
} // namespace mpv_common
} // namespace plezy
#endif // PLEZY_SHARED_MPV_PLAYER_COMMON_H_