Files
plezy/lib/widgets/video_controls/playback_extras_loader.dart
T
edde746 f78f65faf5 chore(player): report marker counts when loading playback extras
The extras loader logged only the chapter count, so a user report of
"auto skip never fires" could not be told apart from "the server has no
intro marker for this item" — the two need opposite fixes. Log the
marker count and types on all three load paths, including the cache-only
one that previously logged nothing at all.

Drop PlexVideoPlaybackData.markers while here: the playback-start parse
filled it on every item and no caller ever read it, because the player
controls fetch their own PlaybackExtras.

Document why getPlaybackExtras may serve the shared metadata cache row
without a freshness check: getPlaybackInitialization refreshes that row
network-first before the controls mount. That ordering is what makes
cache-first correct, and nothing said so.
2026-08-02 04:55:54 +02:00

106 lines
4.2 KiB
Dart

import '../../database/app_database.dart';
import '../../media/ids.dart';
import '../../media/media_item.dart';
import '../../media/media_server_client.dart';
import '../../media/media_source_info.dart';
import '../../services/cached_playback_metadata_service.dart';
import '../../services/settings_service.dart';
import '../../utils/app_logger.dart';
import '../../utils/global_key_utils.dart';
class VideoControlsPlaybackExtrasLoader {
final MediaItem metadata;
final MediaServerClient? client;
final AppDatabase database;
const VideoControlsPlaybackExtrasLoader({required this.metadata, required this.database, required this.client});
Future<PlaybackExtras?> load({bool forceRefresh = false}) async {
if (client == null) {
return _loadFromCacheOnly(cacheServerId: await _resolveCacheServerId());
}
try {
appLogger.d('_loadPlaybackExtras: starting for ${metadata.id} (forceRefresh=$forceRefresh)');
final settings = await SettingsService.getInstance();
final extras = await client!.fetchPlaybackExtras(
metadata.id,
introPattern: settings.read(SettingsService.introPattern),
creditsPattern: settings.read(SettingsService.creditsPattern),
forceChapterFallback: settings.read(SettingsService.forceSkipMarkerFallback),
forceRefresh: forceRefresh,
);
appLogger.d('_loadPlaybackExtras: got ${_describe(extras)}');
return extras;
} catch (e, stack) {
appLogger.d('_loadPlaybackExtras: network path failed, trying cache fallback');
try {
final settings = await SettingsService.getInstance();
final extras = await client!.fetchPlaybackExtrasFromCacheOnly(
metadata.id,
introPattern: settings.read(SettingsService.introPattern),
creditsPattern: settings.read(SettingsService.creditsPattern),
forceChapterFallback: settings.read(SettingsService.forceSkipMarkerFallback),
);
if (extras != null) {
appLogger.d('_loadPlaybackExtras: loaded ${_describe(extras)} from cache');
return extras;
}
} catch (cacheError) {
appLogger.d('_loadPlaybackExtras: cache fallback failed', error: cacheError);
}
appLogger.e('_loadPlaybackExtras failed', error: e, stackTrace: stack);
return null;
}
}
Future<PlaybackExtras?> _loadFromCacheOnly({required String? cacheServerId}) async {
if (cacheServerId == null) {
appLogger.w('_loadPlaybackExtras: no client or cache scope for server ${metadata.serverId}');
return null;
}
try {
final settings = await SettingsService.getInstance();
final extras = await CachedPlaybackMetadataService.fetchPlaybackExtras(
backend: metadata.backend,
cacheServerId: cacheServerId,
itemId: metadata.id,
introPattern: settings.read(SettingsService.introPattern),
creditsPattern: settings.read(SettingsService.creditsPattern),
forceChapterFallback: settings.read(SettingsService.forceSkipMarkerFallback),
);
appLogger.d(
extras == null
? '_loadPlaybackExtras: no cached extras for ${metadata.id}'
: '_loadPlaybackExtras: cache-only ${_describe(extras)}',
);
return extras;
} catch (e) {
appLogger.d('_loadPlaybackExtras: cache-only path failed', error: e);
return null;
}
}
/// Marker counts are the difference between "the server has no intro data"
/// and "auto-skip never fired", which is otherwise indistinguishable in a
/// user-supplied log.
static String _describe(PlaybackExtras extras) {
final markerTypes = extras.markers.map((m) => m.type).join(',');
return '${extras.chapters.length} chapters, ${extras.markers.length} markers'
'${markerTypes.isEmpty ? '' : ' ($markerTypes)'}';
}
Future<String?> _resolveCacheServerId() async {
final serverId = metadata.serverId;
if (serverId == null) return null;
try {
final row = await (database.select(
database.downloadedMedia,
)..where((tbl) => tbl.globalKey.equals(buildGlobalKey(ServerId(serverId), metadata.id)))).getSingleOrNull();
return row?.clientScopeId ?? serverId;
} catch (_) {
return serverId;
}
}
}