edde746
41ffaa7f2b
Plezy declares appCategory="video", so on Android Automotive OS it is a parked app bound by car app quality DD-2/DD-3: audio must stop when the vehicle starts driving and must not be resumable while driving. Two paths kept audio alive. Music playback ran under a mediaPlayback foreground service whose lifecycle observer was registered for Apple TV only, so it never paused when Android backgrounded the app. Video pausing hung off AppLifecycleState.hidden, which Flutter only synthesizes once Android delivers onStop; a car without the Automotive compatibility mode delivers onPause alone, which maps to AppLifecycleState.inactive and the player ignored. Gate every path that can start audio on a new lifecycle predicate, automotivePlaybackAllowed, which permits playback on a car only while the app is resumed and fails closed on an unknown lifecycle state. That covers explicit play, gapless arming and track transitions, live retry and channel switch, frame-rate-match resume, VOD/live startup, and the queue navigation commands of the OS media session, plus a last-resort pause for when the platform player resumes itself on native audio-focus regain. Playback authority on the media-session router is deliberately left alone: the router consumes a denied event, so gating it would swallow PauseEvent and leave the OS unable to stop audio. Reacting to lifecycle callbacks is the mechanism the platform documents as sufficient, so no android.car dependency is added. The music queue no longer requests POST_NOTIFICATIONS on a car, where the foreground service and its notification never start: there is nothing to authorize, and the prompt would take focus and make the gate discard the first play intent. Detect the form factor too: FEATURE_AUTOMOTIVE now vetoes the Android TV verdict, so a rotary-only head unit no longer inherits the leanback experience. Picture-in-picture is gated on FEATURE_PICTURE_IN_PICTURE, which cars lack, so the app's UI cannot stay on screen while driving, and nothing forces a preferred orientation on a fixed-orientation display.
304 lines
12 KiB
Dart
304 lines
12 KiB
Dart
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:os_media_controls/os_media_controls.dart';
|
|
import 'package:plezy/media/media_backend.dart';
|
|
import 'package:plezy/media/media_item.dart';
|
|
import 'package:plezy/media/media_kind.dart';
|
|
import 'package:plezy/services/multi_server_manager.dart';
|
|
import 'package:plezy/services/music/music_playback_service.dart';
|
|
import 'package:plezy/services/music/music_playback_service_impl.dart';
|
|
import 'package:plezy/utils/notification_permission.dart';
|
|
import 'package:plezy/utils/platform_detector.dart';
|
|
|
|
import '../../test_helpers/media_items.dart';
|
|
import 'music_playback_service_test.dart' as music_fakes;
|
|
|
|
MediaItem _track(String id) => testMediaItem(
|
|
id: id,
|
|
backend: MediaBackend.plex,
|
|
kind: MediaKind.track,
|
|
title: 'Track $id',
|
|
durationMs: const Duration(minutes: 3).inMilliseconds,
|
|
serverId: 'srv',
|
|
);
|
|
|
|
class _RecordingMediaControlsManager extends music_fakes.FakeMediaControlsManager {
|
|
final List<bool> backgroundModeCalls = [];
|
|
|
|
@override
|
|
Future<void> setBackgroundMode(bool enabled) async {
|
|
backgroundModeCalls.add(enabled);
|
|
}
|
|
}
|
|
|
|
class _Harness {
|
|
_Harness._(this.service, this.controls, this.players, this.serverManager);
|
|
|
|
final MusicPlaybackServiceImpl service;
|
|
final _RecordingMediaControlsManager controls;
|
|
final List<music_fakes.FakePlayer> players;
|
|
final MultiServerManager serverManager;
|
|
|
|
music_fakes.FakePlayer get player => players.single;
|
|
|
|
factory _Harness.create() {
|
|
final controls = _RecordingMediaControlsManager();
|
|
final players = <music_fakes.FakePlayer>[];
|
|
final serverManager = MultiServerManager();
|
|
final service = MusicPlaybackServiceImpl(
|
|
serverManager: serverManager,
|
|
resolver: music_fakes.FakeMusicSourceResolver(),
|
|
audioPlayerFactory: () {
|
|
final player = music_fakes.FakePlayer();
|
|
players.add(player);
|
|
return player;
|
|
},
|
|
mediaControlsFactory: () => controls,
|
|
volumePersistenceWriter: (_) async {},
|
|
);
|
|
return _Harness._(service, controls, players, serverManager);
|
|
}
|
|
|
|
Future<void> start(List<MediaItem> tracks) async {
|
|
await service.playFromList(
|
|
tracks: tracks,
|
|
playContext: const MusicPlayContext(title: 'Test', kind: MusicPlayContextKind.album),
|
|
);
|
|
await pumpEventQueue();
|
|
}
|
|
|
|
void dispose() {
|
|
service.dispose();
|
|
for (final player in players) {
|
|
player.closeControllers();
|
|
}
|
|
controls.closeControllers();
|
|
serverManager.dispose();
|
|
}
|
|
}
|
|
|
|
void main() {
|
|
// A real binding is required to drive lifecycle state, but the bodies below
|
|
// stay plain `test()` so timers and `pumpEventQueue()` run on the real async
|
|
// queue — inside `testWidgets` the fake-async zone never drains them.
|
|
final binding = TestWidgetsFlutterBinding.ensureInitialized();
|
|
|
|
setUp(TvDetectionService.debugReset);
|
|
|
|
tearDown(() {
|
|
TvDetectionService.debugReset();
|
|
});
|
|
|
|
test('play is refused while automotive lifecycle is not resumed', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
|
|
await harness.start([_track('one')]);
|
|
expect(harness.service.status, MusicPlaybackStatus.paused);
|
|
expect(harness.player.state.playing, isFalse);
|
|
|
|
await harness.service.play();
|
|
|
|
expect(harness.player.playCalls, 0);
|
|
expect(harness.player.state.playing, isFalse);
|
|
expect(harness.service.status, MusicPlaybackStatus.paused);
|
|
expect(harness.player.setNextCalls.where((media) => media != null), isEmpty);
|
|
});
|
|
|
|
test('media-session play is refused while automotive lifecycle is not resumed', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
await harness.start([_track('one')]);
|
|
|
|
harness.controls.eventsCtrl.add(const PlayEvent());
|
|
await pumpEventQueue();
|
|
|
|
expect(harness.player.playCalls, 0);
|
|
expect(harness.player.state.playing, isFalse);
|
|
expect(harness.service.status, MusicPlaybackStatus.paused);
|
|
});
|
|
|
|
test('background mode is explicitly disabled on automotive', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
|
|
await harness.start([_track('one')]);
|
|
|
|
expect(harness.controls.backgroundModeCalls, [false]);
|
|
});
|
|
|
|
test('playback remains unrestricted off automotive', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(false);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
|
|
await harness.start([_track('one')]);
|
|
expect(harness.player.state.playing, isTrue);
|
|
expect(harness.service.status, MusicPlaybackStatus.playing);
|
|
expect(harness.controls.backgroundModeCalls, [true]);
|
|
|
|
await harness.service.pause();
|
|
await harness.service.play();
|
|
|
|
expect(harness.player.playCalls, 1);
|
|
expect(harness.player.state.playing, isTrue);
|
|
expect(harness.service.status, MusicPlaybackStatus.playing);
|
|
});
|
|
|
|
test('automotive lifecycle restriction pauses and clears the gapless arm', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
final second = _track('two');
|
|
await harness.start([_track('one'), second]);
|
|
expect(harness.player.armed?.uri, 'fake://${second.id}');
|
|
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
await pumpEventQueue();
|
|
|
|
expect(harness.player.pauseCalls, greaterThanOrEqualTo(1));
|
|
expect(harness.player.armed, isNull);
|
|
expect(harness.player.state.playing, isFalse);
|
|
expect(harness.service.status, MusicPlaybackStatus.paused);
|
|
});
|
|
|
|
test('a transition racing the automotive pause is adopted but cannot keep playing', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
final second = _track('two');
|
|
await harness.start([_track('one'), second]);
|
|
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
harness.player.emitTransition('fake://${second.id}');
|
|
await pumpEventQueue();
|
|
|
|
expect(harness.service.currentTrack?.id, second.id);
|
|
expect(harness.service.status, MusicPlaybackStatus.paused);
|
|
expect(harness.player.state.playing, isFalse);
|
|
expect(harness.player.armed, isNull);
|
|
});
|
|
|
|
test('media-session stop remains unconditional while automotive playback is restricted', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
await harness.start([_track('one')]);
|
|
|
|
harness.controls.eventsCtrl.add(const StopEvent());
|
|
await pumpEventQueue();
|
|
|
|
expect(harness.service.status, MusicPlaybackStatus.idle);
|
|
expect(harness.service.currentTrack, isNull);
|
|
expect(harness.player.stopCalls, 1);
|
|
});
|
|
|
|
test('the gapless arm is restored once automotive restrictions lift', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
final second = _track('two');
|
|
await harness.start([_track('one'), second]);
|
|
expect(harness.player.armed?.uri, 'fake://${second.id}');
|
|
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
await pumpEventQueue();
|
|
expect(harness.player.armed, isNull);
|
|
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed);
|
|
await pumpEventQueue();
|
|
|
|
// Gapless playback survives the park-and-resume cycle, but parking must not
|
|
// restart audio on its own.
|
|
expect(harness.player.armed?.uri, 'fake://${second.id}');
|
|
expect(harness.service.status, MusicPlaybackStatus.paused);
|
|
expect(harness.player.state.playing, isFalse);
|
|
});
|
|
|
|
test('media-session pause still stops audio while automotive playback is restricted', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed);
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
await harness.start([_track('one')]);
|
|
expect(harness.player.state.playing, isTrue);
|
|
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
await pumpEventQueue();
|
|
final pausesAfterRestriction = harness.player.pauseCalls;
|
|
|
|
// The router consumes a denied event, so gating `canControlPlayback` would
|
|
// silently swallow this and leave the OS unable to stop audio.
|
|
harness.controls.eventsCtrl.add(const PauseEvent());
|
|
await pumpEventQueue();
|
|
|
|
expect(harness.player.pauseCalls, greaterThan(pausesAfterRestriction));
|
|
expect(harness.service.status, MusicPlaybackStatus.paused);
|
|
});
|
|
|
|
test('automotive never prompts for notifications, so first play keeps its intent', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(true);
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed);
|
|
NotificationPermission.debugReset();
|
|
addTearDown(NotificationPermission.debugReset);
|
|
addTearDown(() => NotificationPermission.debugRequestOverride = null);
|
|
addTearDown(() => binding.handleAppLifecycleStateChanged(AppLifecycleState.resumed));
|
|
|
|
var prompts = 0;
|
|
// A real prompt takes focus, which would leave the app not resumed and make
|
|
// the gate open the track paused, silently dropping the user's play intent.
|
|
NotificationPermission.debugRequestOverride = () async {
|
|
prompts++;
|
|
binding.handleAppLifecycleStateChanged(AppLifecycleState.inactive);
|
|
};
|
|
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
await harness.start([_track('one')]);
|
|
|
|
// Nothing to authorize: the foreground service never starts on a car.
|
|
expect(prompts, 0);
|
|
expect(harness.controls.backgroundModeCalls, [false]);
|
|
expect(harness.player.state.playing, isTrue);
|
|
expect(harness.service.status, MusicPlaybackStatus.playing);
|
|
});
|
|
|
|
test('other platforms still request the notification permission', () async {
|
|
TvDetectionService.debugSetAutomotiveOverride(false);
|
|
NotificationPermission.debugReset();
|
|
addTearDown(NotificationPermission.debugReset);
|
|
addTearDown(() => NotificationPermission.debugRequestOverride = null);
|
|
|
|
var prompts = 0;
|
|
NotificationPermission.debugRequestOverride = () async => prompts++;
|
|
|
|
final harness = _Harness.create();
|
|
addTearDown(harness.dispose);
|
|
await harness.start([_track('one')]);
|
|
await pumpEventQueue();
|
|
|
|
expect(prompts, 1);
|
|
expect(harness.controls.backgroundModeCalls, [true]);
|
|
});
|
|
}
|