Trakt was the one service outside the tracker abstraction. TraktScrobbleService re-implemented the whole playback lifecycle beside TrackerCoordinator, and TraktSyncService pushed watched state from its own WatchStateNotifier subscription, so the player called two objects at every lifecycle point and one watch could be written twice. TraktTracker now implements RealtimeScrobbleTracker like Simkl; the duplicated player call sites collapse to one each, and Trakt shares the coordinator's ID resolver instead of re-fetching show ids every episode. Capabilities are split so a tracker declares what it is rather than being special-cased: ScrobblePolicy carries each service's own resend/seek rules, EpisodeHistoryTracker names the remote row a per-item history write targets, and SeriesProgressTracker covers one-counter-per-series services. Writes from all four trackers go through a shared TrackerWriteQueue, generalised from the Trakt-only queue, with the legacy Trakt payload migrated on load. Trakt becomes the fourth TrackersProvider slot and TraktAccountProvider is deleted, so one object owns the active session per profile. Two failure paths found while consolidating are fixed here too. The queue's retries only ran on profile bind, connect and app foreground, so a network blip mid-session left queued watches waiting for the next foreground. OfflineModeProvider now notifies on connectivity changes, not just offline-state or WiFi-flag changes, and main.dart flushes the queue when the network returns. The queue also counted every failure toward the five attempts that permanently drop an item, so a rate limit or a service having a bad hour could discard a pending watch - the loss the queue exists to prevent. Only an answer about the write itself now spends an attempt: 4xx counts, while rate limits, 5xx, recoverable token-refresh failures and requests that never arrived do not. A back-off answer also defers that service for the rest of the flush, so a queue holding many rows does not fire all of them at a service that just asked for quiet.
126 lines
4.6 KiB
Dart
126 lines
4.6 KiB
Dart
import 'dart:convert';
|
|
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:http/http.dart' as http;
|
|
import 'package:http/testing.dart';
|
|
import 'package:plezy/models/trakt/trakt_ids.dart';
|
|
import 'package:plezy/models/trakt/trakt_scrobble_request.dart';
|
|
import 'package:plezy/services/trackers/simkl/simkl_client.dart';
|
|
import 'package:plezy/services/trackers/simkl/simkl_constants.dart';
|
|
import 'package:plezy/services/trackers/tracker_exceptions.dart';
|
|
import 'package:plezy/services/trackers/tracker_session.dart';
|
|
import 'package:plezy/services/trackers/trakt/trakt_client.dart';
|
|
|
|
TrackerSession _session({String refreshToken = 'refresh-old'}) {
|
|
final now = DateTime.now().millisecondsSinceEpoch ~/ 1000;
|
|
return TrackerSession(
|
|
accessToken: 'access-old',
|
|
refreshToken: refreshToken,
|
|
expiresAt: now + 86400,
|
|
createdAt: now,
|
|
username: 'alice',
|
|
);
|
|
}
|
|
|
|
const _scrobble = TraktScrobbleRequest.movie(ids: TraktIds(trakt: 1));
|
|
|
|
void main() {
|
|
group('Trakt status ladder', () {
|
|
test('accepts 409 on scrobble but not on other requests', () async {
|
|
final client = TraktClient(
|
|
_session(),
|
|
onSessionInvalidated: () => fail('409 should not invalidate the session'),
|
|
httpClient: MockClient((_) async => http.Response('conflict', 409)),
|
|
);
|
|
addTearDown(client.dispose);
|
|
|
|
await client.scrobbleStart(_scrobble);
|
|
|
|
await expectLater(
|
|
client.getUserSettings(),
|
|
throwsA(isA<TrackerApiException>().having((e) => e.statusCode, 'statusCode', 409)),
|
|
);
|
|
});
|
|
|
|
test('propagates the refresh TrackerAuthException after a 401', () async {
|
|
var invalidated = 0;
|
|
final client = TraktClient(
|
|
_session(refreshToken: 'refresh-ladder'),
|
|
onSessionInvalidated: () => invalidated++,
|
|
httpClient: MockClient((request) async {
|
|
if (request.url.path == '/oauth/token') {
|
|
return http.Response(json.encode({'error': 'invalid_grant'}), 400);
|
|
}
|
|
return http.Response('unauthorized', 401);
|
|
}),
|
|
);
|
|
addTearDown(client.dispose);
|
|
|
|
await expectLater(
|
|
client.getUserSettings(),
|
|
throwsA(isA<TrackerAuthException>().having((e) => e.isPermanent, 'isPermanent', isTrue)),
|
|
);
|
|
expect(invalidated, 1);
|
|
});
|
|
});
|
|
|
|
group('Simkl status ladder', () {
|
|
test('only the authenticated host invalidates on 401', () async {
|
|
var invalidated = 0;
|
|
final client = SimklClient(
|
|
_session(),
|
|
onSessionInvalidated: () => invalidated++,
|
|
httpClient: MockClient((_) async => http.Response('unauthorized', 401)),
|
|
);
|
|
addTearDown(client.dispose);
|
|
|
|
await expectLater(client.getTrending(SimklCatalogType.tv), throwsA(isA<TrackerApiException>()));
|
|
expect(invalidated, 0);
|
|
|
|
await expectLater(
|
|
client.getUserSettings(),
|
|
throwsA(isA<TrackerAuthException>().having((e) => e.isPermanent, 'isPermanent', isTrue)),
|
|
);
|
|
expect(invalidated, 1);
|
|
});
|
|
|
|
test('surfaces 429 as a plain API failure', () async {
|
|
final client = SimklClient(
|
|
_session(),
|
|
onSessionInvalidated: () => fail('429 should not invalidate the session'),
|
|
httpClient: MockClient((_) async => http.Response('slow down', 429, headers: {'retry-after': '23'})),
|
|
);
|
|
addTearDown(client.dispose);
|
|
|
|
await expectLater(
|
|
client.getUserSettings(),
|
|
throwsA(
|
|
allOf(
|
|
isA<TrackerApiException>().having((e) => e.statusCode, 'statusCode', 429),
|
|
isNot(isA<TrackerRateLimitException>()),
|
|
),
|
|
),
|
|
);
|
|
});
|
|
|
|
// Simkl documents 409 for /scrobble/stop only: the item was already marked
|
|
// watched within the last hour, which is a success for our purposes. Every
|
|
// other endpoint, scrobble or not, still treats it as a failure.
|
|
test('accepts 409 on a scrobble stop but not on start, pause or anything else', () async {
|
|
final client = SimklClient(
|
|
_session(),
|
|
onSessionInvalidated: () => fail('409 should not invalidate the session'),
|
|
httpClient: MockClient((_) async => http.Response('{"watched_at":"2026-07-30T10:30:00.000Z"}', 409)),
|
|
);
|
|
addTearDown(client.dispose);
|
|
|
|
await client.scrobble('stop', const {'progress': 90}, allowConflict: true);
|
|
|
|
final conflict = isA<TrackerApiException>().having((e) => e.statusCode, 'statusCode', 409);
|
|
await expectLater(client.scrobble('start', const {'progress': 0}), throwsA(conflict));
|
|
await expectLater(client.scrobble('pause', const {'progress': 50}), throwsA(conflict));
|
|
await expectLater(client.addToHistory(const {}), throwsA(conflict));
|
|
});
|
|
});
|
|
}
|