edde746
bbed260169
A television raised the whole OSD and timebar on every playback start. The chrome controller is born visible, and its auto-hide clock cannot arm until the first frame lands, so the controls did not merely appear early: they appeared exactly when the picture did, and then sat over the opening five seconds of every movie and episode. The timeline is gated behind the first frame, so the bar materialised on top of the video rather than over the loading spinner, which is what makes it read as a pop-up rather than as chrome that was already there. The route now opens with no chrome on TV. Nothing is lost: the loading spinner and buffering overlay are their own overlays, the screen focus node owns back, and the first D-pad press raises the controls the way it already does after every auto-hide. Pointer and touch platforms keep the chrome, where the viewer's hand is on the surface and the title and back affordance belong over the spinner. Initial presentation now follows initial visibility. They were separate: seeding only visibility would leave the route claiming its chrome was still presented, so PlayerNavigationCoordinator would read back as "hide the chrome", hide() would no-op against chrome that was never up, and the press would be swallowed instead of leaving the player. Controls that mount with the chrome already down now claim focus themselves. Focus normally reaches them through the hide transition, and their own autofocus cannot win it back because the screen node took it during the loading phase. Left alone, the screen node kept primary focus and its self-heal raised the entire OSD on the first D-pad press, which put the chrome straight back over the picture and bypassed the transient seek and transport indicators. Both player spinners now carry a label. They were bare progress indicators, so a screen reader announced nothing at all while the picture was coming up, and the TV Maestro flows had no way left to tell a loading player from a playing one once the Pause button stopped appearing on its own. The two TV flows are repaired to match. They waited on that button, and now wait for the labelled spinner to clear, which cannot happen before the media is opened. 05 additionally reaches Search by D-pad rather than a percentage coordinate, because a tap flips InputModeTracker to pointer mode and collapses the rail it is aiming at, and it gates on the play-next prompt's own Cancel action: "Next Episode" is also the credits skip button, so the old assertion could pass without the prompt ever opening. close #1765
81 lines
2.6 KiB
YAML
81 lines
2.6 KiB
YAML
appId: com.edde746.plezy
|
|
name: TV hardware media and back keys follow player chrome state
|
|
|
|
tags:
|
|
- e2e
|
|
- regression
|
|
- tv
|
|
- playback
|
|
---
|
|
- runFlow: ../subflows/onboard_jellyfin_tv.yaml
|
|
- pressKey: "Remote Dpad Center"
|
|
- waitForAnimationToEnd:
|
|
timeout: 5000
|
|
- runFlow:
|
|
when:
|
|
visible: "(?s)^(Play|Resume).*$"
|
|
commands:
|
|
- pressKey: "Remote Dpad Center"
|
|
# The TV player opens with its chrome down so the OSD and timebar never sit
|
|
# over the opening seconds of the picture (#1765), so the Pause button can no
|
|
# longer stand in for "the player has finished loading". Wait for the detail
|
|
# screen to go first: the labelled spinner is necessarily up the moment the
|
|
# player route owns the frame, and it only clears once playback reports its
|
|
# first frame or gives up, so this can never advance before the media opens.
|
|
# A give-up lands on the transport assertions below, which is where it belongs.
|
|
- extendedWaitUntil:
|
|
notVisible: "Overview"
|
|
timeout: 30000
|
|
- extendedWaitUntil:
|
|
notVisible: "Loading video"
|
|
timeout: 30000
|
|
- assertNotVisible: "(?s)^(Play|Pause)$"
|
|
# Hardware transport keys drive playback without raising the chrome (#1676):
|
|
# the player answers with a centred disc (pause) or a side readout (seek), never the
|
|
# full chrome, so subtitles stay readable.
|
|
# Pause first — it also freezes the clip, so the seek assertions below cannot
|
|
# race the end of a short fixture item.
|
|
- pressKey: "Remote Media Play Pause"
|
|
- extendedWaitUntil:
|
|
visible: "Paused"
|
|
timeout: 10000
|
|
- assertNotVisible: "(?s)^Play$"
|
|
# D-pad seeking reports through the skip badge, never the scrub bar, and
|
|
# consecutive presses in one direction stack into a running total.
|
|
- pressKey: "Remote Dpad Right"
|
|
- extendedWaitUntil:
|
|
visible: "(?s)^Seek forward 10 seconds$"
|
|
timeout: 10000
|
|
- assertNotVisible: "(?s)^Play$"
|
|
- pressKey: "Remote Dpad Right"
|
|
- extendedWaitUntil:
|
|
visible: "(?s)^Seek forward 20 seconds$"
|
|
timeout: 10000
|
|
- pressKey: "Remote Media Play Pause"
|
|
- extendedWaitUntil:
|
|
visible: "Playing"
|
|
timeout: 10000
|
|
- assertNotVisible: "(?s)^Pause$"
|
|
# Select stays the deliberate way to bring the chrome back.
|
|
- pressKey: "Remote Dpad Center"
|
|
- extendedWaitUntil:
|
|
visible: "(?s)^(Play|Pause)$"
|
|
timeout: 10000
|
|
- pressKey: "back"
|
|
- extendedWaitUntil:
|
|
notVisible: "(?s)^Pause$"
|
|
timeout: 10000
|
|
- assertNotVisible: "Overview"
|
|
- pressKey: "back"
|
|
- waitForAnimationToEnd:
|
|
timeout: 5000
|
|
- runFlow:
|
|
when:
|
|
visible: "Overview"
|
|
commands:
|
|
- pressKey: "back"
|
|
- extendedWaitUntil:
|
|
visible:
|
|
id: "tv_browse_rail_selection"
|
|
timeout: 15000
|