Files
plezy/test/widgets/media_card_square_test.dart
T
edde746 c64e6fc519 fix(artwork): stop memoizing posters that merely have no client yet
Distinguish an unresolvable URL from a failed load at the error-widget
boundary. A transiently null media client during a profile switch or
reconnect marked the primary poster dead in a process-global set, pinning the
item to fallback artwork for the rest of the session.
2026-07-27 17:44:52 +02:00

273 lines
11 KiB
Dart

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:plezy/media/media_backend.dart';
import 'package:plezy/media/media_item.dart';
import 'package:plezy/media/media_kind.dart';
import 'package:plezy/media/media_playlist.dart';
import 'package:plezy/services/settings_service.dart';
import 'package:plezy/theme/mono_theme.dart';
import 'package:plezy/utils/layout_constants.dart';
import 'package:plezy/utils/media_image_helper.dart';
import 'package:plezy/widgets/media_card.dart';
import 'package:plezy/widgets/media_card_list_layout.dart';
import 'package:plezy/widgets/media_grid_delegate.dart';
import 'package:plezy/widgets/optimized_media_image.dart';
import 'package:plezy/widgets/watched_indicator.dart';
import '../test_helpers/prefs.dart';
import '../test_helpers/media_items.dart';
MediaItem _item(MediaKind kind, {String? parentTitle, int? durationMs}) => testMediaItem(
id: '${kind.id}_1',
backend: MediaBackend.plex,
kind: kind,
title: 'Test ${kind.id}',
parentTitle: parentTitle,
durationMs: durationMs,
);
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
setUp(() async {
resetSharedPreferencesForTest();
SettingsService.resetForTesting();
await SettingsService.getInstance();
});
test('music items resolve to the square card shape', () {
for (final kind in [MediaKind.artist, MediaKind.album, MediaKind.track]) {
expect(_item(kind).cardShape(EpisodePosterMode.seriesPoster), CardShape.square);
expect(_item(kind).cardShape(EpisodePosterMode.episodeThumbnail), CardShape.square);
}
expect(_item(MediaKind.movie).cardShape(EpisodePosterMode.seriesPoster), CardShape.poster);
expect(_item(MediaKind.episode).cardShape(EpisodePosterMode.episodeThumbnail), CardShape.wide);
});
test('square grid delegates use square aspect ratios, defaults unchanged', () {
expect(MediaGridDelegate.aspectRatioFor(shape: CardShape.square), GridLayoutConstants.squareGridCellAspectRatio);
expect(
MediaGridDelegate.aspectRatioFor(shape: CardShape.square, fullBleedImage: true),
GridLayoutConstants.squareAspectRatio,
);
// Shape wins over the legacy bool when both are provided.
expect(
MediaGridDelegate.aspectRatioFor(shape: CardShape.square, useWideAspectRatio: true),
GridLayoutConstants.squareGridCellAspectRatio,
);
// Existing behavior is untouched when shape isn't passed.
expect(MediaGridDelegate.aspectRatioFor(), GridLayoutConstants.posterAspectRatio);
expect(MediaGridDelegate.aspectRatioFor(useWideAspectRatio: true), GridLayoutConstants.episodeGridCellAspectRatio);
});
test('list layout sizes square cards 1:1', () {
final base = MediaCardListLayout.basePosterWidth(LibraryDensity.defaultValue);
expect(MediaCardListLayout.posterWidth(density: LibraryDensity.defaultValue, shape: CardShape.square), base);
expect(MediaCardListLayout.posterHeight(density: LibraryDensity.defaultValue, shape: CardShape.square), base);
// Legacy bool call sites are untouched.
expect(
MediaCardListLayout.posterHeight(density: LibraryDensity.defaultValue, usesWideAspectRatio: false),
base * 1.5,
);
});
testWidgets('album grid card renders a square rounded image with square image type', (tester) async {
// Hub-style explicit dimensions: cardWidth 200 -> posterWidth 194, square height 194.
await tester.pumpWidget(
_TestApp(
child: MediaCard(
item: _item(MediaKind.album, parentTitle: 'Album Artist'),
width: 200,
height: 194,
forceGridMode: true,
isOffline: true,
),
),
);
final clip = find.descendant(of: find.byType(MediaCard), matching: find.byType(ClipRRect));
expect(tester.getSize(clip.first), const Size(194, 194));
expect(find.descendant(of: find.byType(MediaCard), matching: find.byType(ClipOval)), findsNothing);
expect(tester.widget<OptimizedMediaImage>(find.byType(OptimizedMediaImage)).imageType, ImageType.square);
// Albums keep the watched overlay; subtitle shows the album artist.
expect(find.byType(WatchedIndicator), findsOneWidget);
expect(find.text('Album Artist'), findsOneWidget);
});
testWidgets('artist grid card clips to a circle and skips the watched overlay', (tester) async {
await tester.pumpWidget(
_TestApp(
child: MediaCard(item: _item(MediaKind.artist), width: 200, height: 194, forceGridMode: true, isOffline: true),
),
);
final oval = find.descendant(of: find.byType(MediaCard), matching: find.byType(ClipOval));
expect(tester.getSize(oval), const Size(194, 194));
expect(tester.widget<OptimizedMediaImage>(find.byType(OptimizedMediaImage)).imageType, ImageType.square);
expect(find.byType(WatchedIndicator), findsNothing);
});
testWidgets('movie grid card still renders the 2:3 poster', (tester) async {
await tester.pumpWidget(
_TestApp(
child: MediaCard(item: _item(MediaKind.movie), width: 200, height: 291, forceGridMode: true, isOffline: true),
),
);
final clip = find.descendant(of: find.byType(MediaCard), matching: find.byType(ClipRRect));
expect(tester.getSize(clip.first), const Size(194, 291));
expect(find.descendant(of: find.byType(MediaCard), matching: find.byType(ClipOval)), findsNothing);
expect(tester.widget<OptimizedMediaImage>(find.byType(OptimizedMediaImage)).imageType, ImageType.poster);
});
testWidgets('track list card uses a square image area', (tester) async {
await tester.pumpWidget(
_TestApp(
child: SizedBox(
width: 420,
height: 160,
child: MediaCard(
item: _item(MediaKind.track, parentTitle: 'Album', durationMs: 200000),
forceListMode: true,
isOffline: true,
),
),
),
);
final base = MediaCardListLayout.basePosterWidth(LibraryDensity.defaultValue);
final imageBox = find.descendant(of: find.byType(MediaCard), matching: find.byType(ClipRRect)).first;
expect(tester.getSize(imageBox), Size(base, base));
});
testWidgets('music collection override renders square artwork and requests a square transcode', (tester) async {
await tester.pumpWidget(
_TestApp(
child: MediaCard(
item: _item(MediaKind.collection),
width: 200,
height: 194,
forceGridMode: true,
isOffline: true,
cardShapeOverride: CardShape.square,
),
),
);
final imageBox = find.descendant(of: find.byType(MediaCard), matching: find.byType(ClipRRect)).first;
expect(tester.getSize(imageBox), const Size(194, 194));
expect(tester.widget<OptimizedMediaImage>(find.byType(OptimizedMediaImage)).imageType, ImageType.square);
});
testWidgets('music playlist override uses square artwork in list mode', (tester) async {
const playlist = MediaPlaylist(
id: 'playlist_1',
backend: MediaBackend.plex,
title: 'Music playlist',
playlistType: 'audio',
);
await tester.pumpWidget(
const _TestApp(
child: SizedBox(
width: 420,
height: 160,
child: MediaCard(item: playlist, forceListMode: true, isOffline: true, cardShapeOverride: CardShape.square),
),
),
);
final base = MediaCardListLayout.basePosterWidth(LibraryDensity.defaultValue);
final imageBox = find.descendant(of: find.byType(MediaCard), matching: find.byType(ClipRRect)).first;
expect(tester.getSize(imageBox), Size(base, base));
expect(tester.widget<OptimizedMediaImage>(find.byType(OptimizedMediaImage)).imageType, ImageType.square);
});
testWidgets('track artwork failure falls back to album artwork', (tester) async {
const trackArtwork = 'https://media.example/track.jpg';
const albumArtwork = 'https://media.example/album.jpg';
final item = testMediaItem(
id: 'track-with-fallback',
backend: MediaBackend.jellyfin,
kind: MediaKind.track,
title: 'Track',
thumbPath: trackArtwork,
parentThumbPath: albumArtwork,
);
await tester.pumpWidget(
_TestApp(child: MediaCard(item: item, width: 200, height: 194, forceGridMode: true, isOffline: true)),
);
final primaryFinder = find.descendant(of: find.byType(MediaCard), matching: find.byType(OptimizedMediaImage)).first;
final primary = tester.widget<OptimizedMediaImage>(primaryFinder);
expect(primary.imagePath, trackArtwork);
expect(primary.errorWidget, isNotNull);
final fallback = primary.errorWidget!(tester.element(primaryFinder), trackArtwork, StateError('decode failed'));
expect(fallback, isA<OptimizedMediaImage>());
expect((fallback as OptimizedMediaImage).imagePath, albumArtwork);
expect(fallback.imageType, ImageType.square);
});
testWidgets('unresolved track artwork fallback is not memoized', (tester) async {
const trackArtwork = 'https://poster-memo.example/unresolved-track.jpg';
const albumArtwork = 'https://poster-memo.example/unresolved-album.jpg';
final item = testMediaItem(
id: 'track-with-unresolved-artwork',
backend: MediaBackend.jellyfin,
kind: MediaKind.track,
title: 'Track',
thumbPath: trackArtwork,
parentThumbPath: albumArtwork,
);
Future<void> pumpCard() => tester.pumpWidget(
_TestApp(child: MediaCard(item: item, width: 200, height: 194, forceGridMode: true, isOffline: true)),
);
await pumpCard();
final primaryFinder = find.descendant(of: find.byType(MediaCard), matching: find.byType(OptimizedMediaImage)).first;
final primary = tester.widget<OptimizedMediaImage>(primaryFinder);
expect(primary.imagePath, trackArtwork);
expect(primary.errorWidget, isNotNull);
final unresolvedFallback = primary.errorWidget!(
tester.element(primaryFinder),
trackArtwork,
const UnresolvedImageUrl(trackArtwork),
);
expect(unresolvedFallback, isA<OptimizedMediaImage>());
expect((unresolvedFallback as OptimizedMediaImage).imagePath, albumArtwork);
await pumpCard();
final unresolvedRebuild = tester.widget<OptimizedMediaImage>(primaryFinder);
expect(unresolvedRebuild.imagePath, trackArtwork);
final failedFallback = unresolvedRebuild.errorWidget!(
tester.element(primaryFinder),
trackArtwork,
StateError('decode failed'),
);
expect(failedFallback, isA<OptimizedMediaImage>());
expect((failedFallback as OptimizedMediaImage).imagePath, albumArtwork);
await pumpCard();
expect(tester.widget<OptimizedMediaImage>(primaryFinder).imagePath, albumArtwork);
});
}
class _TestApp extends StatelessWidget {
final Widget child;
const _TestApp({required this.child});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: monoTheme(dark: true),
home: Scaffold(body: Center(child: child)),
);
}
}