Plex treats a subtitle stream as forced when its title says "Forced" even with the API flag unset. Every forced comparison now uses that effective forced-ness on both sides: the match scorer, the low-metadata hard gate, the Jellyfin OnlyForced/Smart profile modes, and stream-index negotiation. Carrying a track choice into the next episode no longer reuses the same-item identity matchers. A sealed SubtitlePreference (off / track reference / semantic intent) replaces the id-'navigation' pseudo-track through the whole preference channel, and cross-item intents hard-require language and forced-class parity. When the next episode has no track of the same class, the intent declines and selection falls through to the server's own per-episode choice instead of latching onto a full track by position and persisting that mistake back to the server. Intents wait for pending native tracks under the same catalog-completeness rule as source ids, so an early decline cannot retire the selection listener before the real track arrives. Ref #1716
214 lines
7.6 KiB
Dart
214 lines
7.6 KiB
Dart
import 'dart:async';
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/services.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:plezy/focus/focusable_button.dart';
|
|
import 'package:plezy/providers/playback_state_provider.dart';
|
|
import 'package:plezy/mpv/mpv.dart';
|
|
import 'package:plezy/screens/video_player_screen.dart';
|
|
import 'package:plezy/services/settings_service.dart';
|
|
import 'package:plezy/services/subtitle_preference.dart';
|
|
import 'package:provider/provider.dart';
|
|
|
|
import '../../test_helpers/media_items.dart';
|
|
import '../../test_helpers/mock_player_channels.dart';
|
|
import '../../test_helpers/prefs.dart';
|
|
|
|
void main() {
|
|
TestWidgetsFlutterBinding.ensureInitialized();
|
|
|
|
setUp(() async {
|
|
resetSharedPreferencesForTest();
|
|
SettingsService.resetForTesting();
|
|
await SettingsService.getInstance();
|
|
});
|
|
|
|
test('in-place reload preserves the current playback intent', () {
|
|
expect(
|
|
shouldAutoStartReloadedMedia(wasPlayingBeforeReload: false, watchTogetherOwnsStart: false, startPaused: false),
|
|
isFalse,
|
|
);
|
|
expect(
|
|
shouldAutoStartReloadedMedia(wasPlayingBeforeReload: true, watchTogetherOwnsStart: false, startPaused: false),
|
|
isTrue,
|
|
);
|
|
expect(
|
|
shouldAutoStartReloadedMedia(wasPlayingBeforeReload: true, watchTogetherOwnsStart: true, startPaused: false),
|
|
isFalse,
|
|
);
|
|
expect(
|
|
shouldAutoStartReloadedMedia(wasPlayingBeforeReload: true, watchTogetherOwnsStart: false, startPaused: true),
|
|
isFalse,
|
|
);
|
|
});
|
|
|
|
test('item-change subtitle preference carries committed semantics without item identity', () {
|
|
const committed = SubtitleTrack(
|
|
id: 'source:4',
|
|
title: 'French - SRT',
|
|
language: 'fra',
|
|
codec: 'srt',
|
|
isForced: true,
|
|
isExternal: true,
|
|
uri: 'https://example.test/old-episode/subtitle.srt',
|
|
);
|
|
|
|
final result = subtitlePreferenceForItemChange(
|
|
hasCommittedSelection: true,
|
|
committedTrack: committed,
|
|
nativeTrack: SubtitleTrack.off,
|
|
);
|
|
|
|
expect(result, isA<SubtitleIntentPreference>());
|
|
final intent = (result! as SubtitleIntentPreference).intent;
|
|
expect(intent.title, committed.title);
|
|
expect(intent.language, committed.language);
|
|
expect(intent.codec, committed.codec);
|
|
expect(intent.forced, isTrue);
|
|
expect(intent.isExternal, isTrue);
|
|
});
|
|
|
|
test('item-change subtitle preference derives forced-ness from a forced title (#1716)', () {
|
|
const committed = SubtitleTrack(id: 'source:4', title: 'FR Forced [ASS]', language: 'fra', codec: 'ass');
|
|
|
|
final result = subtitlePreferenceForItemChange(
|
|
hasCommittedSelection: true,
|
|
committedTrack: committed,
|
|
nativeTrack: SubtitleTrack.off,
|
|
);
|
|
|
|
expect(result, isA<SubtitleIntentPreference>());
|
|
expect((result! as SubtitleIntentPreference).intent.forced, isTrue);
|
|
});
|
|
|
|
test('item-change subtitle preference preserves committed off and empty secondary slots', () {
|
|
expect(
|
|
subtitlePreferenceForItemChange(
|
|
hasCommittedSelection: true,
|
|
committedTrack: SubtitleTrack.off,
|
|
nativeTrack: const SubtitleTrack(id: '7', language: 'eng'),
|
|
),
|
|
const SubtitlePreference.off(),
|
|
);
|
|
expect(
|
|
subtitlePreferenceForItemChange(
|
|
hasCommittedSelection: true,
|
|
committedTrack: null,
|
|
nativeTrack: const SubtitleTrack(id: '8', language: 'swe'),
|
|
),
|
|
const SubtitlePreference.off(),
|
|
);
|
|
});
|
|
|
|
test('item-change subtitle preference uses native metadata only without a committed selection', () {
|
|
final result = subtitlePreferenceForItemChange(
|
|
hasCommittedSelection: false,
|
|
committedTrack: null,
|
|
nativeTrack: const SubtitleTrack(
|
|
id: '9',
|
|
title: 'English',
|
|
language: 'eng',
|
|
uri: 'https://example.test/old-episode/native.srt',
|
|
),
|
|
);
|
|
|
|
expect(result, isA<SubtitleIntentPreference>());
|
|
expect((result! as SubtitleIntentPreference).intent.language, 'eng');
|
|
});
|
|
|
|
testWidgets('initialization ownership serializes rollback, retry, and route removal', (tester) async {
|
|
final failedDispose = Completer<void>();
|
|
final replacementInitialize = Completer<bool>();
|
|
final calls = <MethodCall>[];
|
|
final eventCalls = <MethodCall>[];
|
|
var initializeCount = 0;
|
|
|
|
await withMockPlayerChannels(
|
|
methodChannelName: 'com.plezy/mpv_player',
|
|
eventChannelName: 'com.plezy/mpv_player/events',
|
|
methodHandler: (call) {
|
|
calls.add(call);
|
|
switch (call.method) {
|
|
case 'initialize':
|
|
initializeCount++;
|
|
if (initializeCount == 2) return replacementInitialize.future;
|
|
return Future<Object?>.value(true);
|
|
case 'observeProperty':
|
|
if (initializeCount == 1) {
|
|
throw PlatformException(code: 'post_creation_failure', message: 'forced observation failure');
|
|
}
|
|
return Future<Object?>.value(null);
|
|
case 'dispose':
|
|
if (initializeCount == 1) return failedDispose.future;
|
|
return Future<Object?>.value(null);
|
|
default:
|
|
return Future<Object?>.value(null);
|
|
}
|
|
},
|
|
eventHandler: (call) async {
|
|
eventCalls.add(call);
|
|
return null;
|
|
},
|
|
testBody: () async {
|
|
final key = GlobalKey<VideoPlayerScreenState>();
|
|
await tester.pumpWidget(_screen(key));
|
|
await _pumpUntil(tester, () => calls.any((call) => call.method == 'dispose'));
|
|
|
|
expect(key.currentState?.player, isNull);
|
|
expect(find.widgetWithText(FilledButton, 'Retry'), findsNothing);
|
|
expect(initializeCount, 1);
|
|
expect(eventCalls.where((call) => call.method == 'cancel'), hasLength(1));
|
|
|
|
failedDispose.complete();
|
|
await _pumpUntil(tester, () => find.widgetWithText(FilledButton, 'Retry').evaluate().isNotEmpty);
|
|
|
|
final retryButton = tester.widget<FilledButton>(find.widgetWithText(FilledButton, 'Retry'));
|
|
final retryFocusable = tester.widget<FocusableButton>(
|
|
find.ancestor(of: find.widgetWithText(FilledButton, 'Retry'), matching: find.byType(FocusableButton)),
|
|
);
|
|
retryButton.onPressed!();
|
|
retryFocusable.onPressed!();
|
|
await _pumpUntil(tester, () => initializeCount == 2);
|
|
|
|
expect(initializeCount, 2);
|
|
expect(key.currentState?.player, isNull);
|
|
expect(calls.where((call) => call.method == 'dispose'), hasLength(1));
|
|
expect(eventCalls.where((call) => call.method == 'cancel'), hasLength(1));
|
|
|
|
await tester.pumpWidget(const SizedBox.shrink());
|
|
replacementInitialize.completeError(PlatformException(code: 'late_failure', message: 'forced late failure'));
|
|
await _pumpUntil(tester, () => calls.where((call) => call.method == 'dispose').length == 2);
|
|
|
|
expect(find.widgetWithText(FilledButton, 'Retry'), findsNothing);
|
|
expect(initializeCount, 2);
|
|
expect(calls.where((call) => call.method == 'dispose'), hasLength(2));
|
|
expect(eventCalls.where((call) => call.method == 'cancel'), hasLength(2));
|
|
},
|
|
);
|
|
});
|
|
}
|
|
|
|
Widget _screen(GlobalKey<VideoPlayerScreenState> key) {
|
|
return ChangeNotifierProvider(
|
|
create: (_) => PlaybackStateProvider(),
|
|
child: MaterialApp(
|
|
home: VideoPlayerScreen(
|
|
key: key,
|
|
metadata: testMediaItem(title: 'Lifecycle test video'),
|
|
isOffline: true,
|
|
),
|
|
),
|
|
);
|
|
}
|
|
|
|
Future<void> _pumpUntil(WidgetTester tester, bool Function() condition) async {
|
|
for (var i = 0; i < 200 && !condition(); i++) {
|
|
await tester.pump(const Duration(milliseconds: 10));
|
|
if (!condition()) {
|
|
await tester.runAsync(() => Future<void>.delayed(const Duration(milliseconds: 5)));
|
|
}
|
|
}
|
|
expect(condition(), isTrue);
|
|
}
|