edde746
daab4f1e24
Plex treats a subtitle stream as forced when its title says "Forced" even with the API flag unset. Every forced comparison now uses that effective forced-ness on both sides: the match scorer, the low-metadata hard gate, the Jellyfin OnlyForced/Smart profile modes, and stream-index negotiation. Carrying a track choice into the next episode no longer reuses the same-item identity matchers. A sealed SubtitlePreference (off / track reference / semantic intent) replaces the id-'navigation' pseudo-track through the whole preference channel, and cross-item intents hard-require language and forced-class parity. When the next episode has no track of the same class, the intent declines and selection falls through to the server's own per-episode choice instead of latching onto a full track by position and persisting that mistake back to the server. Intents wait for pending native tracks under the same catalog-completeness rule as source ids, so an early decline cannot retire the selection listener before the real track arrives. Ref #1716
85 lines
3.2 KiB
Dart
85 lines
3.2 KiB
Dart
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:plezy/mpv/mpv.dart';
|
|
import 'package:plezy/services/subtitle_preference.dart';
|
|
|
|
void main() {
|
|
group('SubtitleIntent.fromTrack', () {
|
|
test('returns null for null, off, and metadata-less tracks', () {
|
|
expect(SubtitleIntent.fromTrack(null), isNull);
|
|
expect(SubtitleIntent.fromTrack(SubtitleTrack.off), isNull);
|
|
expect(SubtitleIntent.fromTrack(const SubtitleTrack(id: '3')), isNull);
|
|
});
|
|
|
|
test('captures effective forced-ness from the title (#1716)', () {
|
|
final intent = SubtitleIntent.fromTrack(
|
|
const SubtitleTrack(id: 'source:8', title: 'FR Forced [ASS]', language: 'fre', codec: 'ass'),
|
|
);
|
|
expect(intent, isNotNull);
|
|
expect(intent!.forced, isTrue);
|
|
expect(intent.language, 'fre');
|
|
});
|
|
|
|
test('captures effective forced-ness from the flag', () {
|
|
final intent = SubtitleIntent.fromTrack(
|
|
const SubtitleTrack(id: '4', language: 'fre', isForced: true),
|
|
);
|
|
expect(intent!.forced, isTrue);
|
|
});
|
|
|
|
test('full track produces a non-forced intent', () {
|
|
final intent = SubtitleIntent.fromTrack(
|
|
const SubtitleTrack(id: '4', title: 'French', language: 'fre', codec: 'srt'),
|
|
);
|
|
expect(intent!.forced, isFalse);
|
|
});
|
|
});
|
|
|
|
group('SubtitlePreference.trackOrNull', () {
|
|
test('maps null, off, and real tracks', () {
|
|
expect(SubtitlePreference.trackOrNull(null), isNull);
|
|
expect(SubtitlePreference.trackOrNull(SubtitleTrack.off), const SubtitlePreference.off());
|
|
const track = SubtitleTrack(id: 'source:5', language: 'eng');
|
|
expect(SubtitlePreference.trackOrNull(track), const SubtitlePreference.track(track));
|
|
});
|
|
});
|
|
|
|
group('SubtitlePreference.demoteToIntent', () {
|
|
test('off and intents pass through, null stays null', () {
|
|
const off = SubtitlePreference.off();
|
|
expect(SubtitlePreference.demoteToIntent(off), off);
|
|
const intent = SubtitlePreference.intent(SubtitleIntent(language: 'fre', forced: true));
|
|
expect(SubtitlePreference.demoteToIntent(intent), intent);
|
|
expect(SubtitlePreference.demoteToIntent(null), isNull);
|
|
});
|
|
|
|
test('track references become intents with effective forced-ness', () {
|
|
final demoted = SubtitlePreference.demoteToIntent(
|
|
const SubtitlePreference.track(SubtitleTrack(id: 'source:8', title: 'FR Forced', language: 'fre', codec: 'ass')),
|
|
);
|
|
expect(
|
|
demoted,
|
|
const SubtitlePreference.intent(
|
|
SubtitleIntent(language: 'fre', forced: true, title: 'FR Forced', codec: 'ass'),
|
|
),
|
|
);
|
|
});
|
|
|
|
test('sidecar uri references also lose their identity', () {
|
|
final demoted = SubtitlePreference.demoteToIntent(
|
|
SubtitlePreference.track(
|
|
SubtitleTrack.uri('https://server/library/streams/9.srt', language: 'eng', codec: 'srt'),
|
|
),
|
|
);
|
|
expect(demoted, isA<SubtitleIntentPreference>());
|
|
expect((demoted! as SubtitleIntentPreference).intent.isExternal, isTrue);
|
|
});
|
|
|
|
test('metadata-less track references demote to null', () {
|
|
expect(
|
|
SubtitlePreference.demoteToIntent(const SubtitlePreference.track(SubtitleTrack(id: '2'))),
|
|
isNull,
|
|
);
|
|
});
|
|
});
|
|
}
|