yorickr/plezy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use dpad controls for settings dialogs in keyboard nav mode

Browse Source
This commit is contained in:
edde746
2026-02-22 15:20:16 +01:00
parent 7f8d4c7946
commit d709d638c7
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/screens/settings/settings_screen.dart
+2 -2
View File
@@ -1100,9 +1100,9 @@ class _SettingsScreenState extends State<SettingsScreen> with FocusableTab {
required int currentValue,
required Future<void> Function(int value) onSave,
}) {
final isTV = PlatformDetector.isTV();
final useDpadControls = InputModeTracker.isKeyboardMode(context);
if (isTV) {
if (useDpadControls) {
_showNumericInputDialogTV(
title: title,
suffixText: suffixText,
lib/screens/settings/subtitle_styling_screen.dart
+10 -8
View File
@@ -5,7 +5,7 @@ import 'package:flex_color_picker/flex_color_picker.dart';
import '../../focus/focusable_button.dart';
import '../../i18n/strings.g.dart';
import '../../services/settings_service.dart';
import '../../utils/platform_detector.dart';
import '../../focus/input_mode_tracker.dart';
import '../../focus/key_event_utils.dart';
import '../../widgets/desktop_app_bar.dart';
import '../../widgets/tv_color_picker.dart';
@@ -335,6 +335,8 @@ class _SubtitleStylingScreenState extends State<SubtitleStylingScreen> {
}
Widget _buildStylingCard() {
final useDpadControls = InputModeTracker.isKeyboardMode(context);
return Card(
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
@@ -347,7 +349,7 @@ class _SubtitleStylingScreenState extends State<SubtitleStylingScreen> {
),
),
// Font Size Slider
if (PlatformDetector.isTV())
if (useDpadControls)
ListTile(
title: Text(t.subtitlingStyling.fontSize),
trailing: Text('$_fontSize'),
@@ -380,7 +382,7 @@ class _SubtitleStylingScreenState extends State<SubtitleStylingScreen> {
),
const Divider(),
// Subtitle Position Slider
if (PlatformDetector.isTV())
if (useDpadControls)
ListTile(
title: Text(t.subtitlingStyling.position),
trailing: Text(() {
@@ -433,7 +435,7 @@ class _SubtitleStylingScreenState extends State<SubtitleStylingScreen> {
_settingsService.setSubtitleTextColor(color);
}
if (PlatformDetector.isTV()) {
if (useDpadControls) {
_showTvColorPicker(t.subtitlingStyling.textColor, _textColor, onColorSelected);
} else {
_showColorPicker(t.subtitlingStyling.textColor, _textColor, onColorSelected);
@@ -442,7 +444,7 @@ class _SubtitleStylingScreenState extends State<SubtitleStylingScreen> {
),
const Divider(),
// Border Size Slider
if (PlatformDetector.isTV())
if (useDpadControls)
ListTile(
title: Text(t.subtitlingStyling.borderSize),
trailing: Text('$_borderSize'),
@@ -485,7 +487,7 @@ class _SubtitleStylingScreenState extends State<SubtitleStylingScreen> {
_settingsService.setSubtitleBorderColor(color);
}
if (PlatformDetector.isTV()) {
if (useDpadControls) {
_showTvColorPicker(t.subtitlingStyling.borderColor, _borderColor, onColorSelected);
} else {
_showColorPicker(t.subtitlingStyling.borderColor, _borderColor, onColorSelected);
@@ -494,7 +496,7 @@ class _SubtitleStylingScreenState extends State<SubtitleStylingScreen> {
),
const Divider(),
// Background Opacity Slider
if (PlatformDetector.isTV())
if (useDpadControls)
ListTile(
title: Text(t.subtitlingStyling.backgroundOpacity),
trailing: Text('$_backgroundOpacity%'),
@@ -540,7 +542,7 @@ class _SubtitleStylingScreenState extends State<SubtitleStylingScreen> {
_settingsService.setSubtitleBackgroundColor(color);
}
if (PlatformDetector.isTV()) {
if (useDpadControls) {
_showTvColorPicker(t.subtitlingStyling.backgroundColor, _backgroundColor, onColorSelected);
} else {
_showColorPicker(t.subtitlingStyling.backgroundColor, _backgroundColor, onColorSelected);